Extract common simulcast logic from VP8 wrapper and simulcast adapter

webrtc/modules/video_coding/codecs/vp8/simulcast_encoder_adapter.h

 /*
  *  Copyright (c) 2014 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  *
  */
 
 #ifndef WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_SIMULCAST_ENCODER_ADAPTER_H_
 #define WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_SIMULCAST_ENCODER_ADAPTER_H_
 
+#include <map>
 #include <memory>
 #include <string>
+#include <utility>
 #include <vector>
 
 #include "webrtc/modules/video_coding/codecs/vp8/include/vp8.h"
 
 namespace webrtc {
 
+class SimulcastState;
+
 class VideoEncoderFactory {
  public:
   virtual VideoEncoder* Create() = 0;
   virtual void Destroy(VideoEncoder* encoder) = 0;
   virtual ~VideoEncoderFactory() {}
 };
 
 // SimulcastEncoderAdapter implements simulcast support by creating multiple
 // webrtc::VideoEncoder instances with the given VideoEncoderFactory.
 // All the public interfaces are expected to be called from the same thread,
@@ skipping 51 matching lines @@
           send_stream(send_stream) {}
     // Deleted by SimulcastEncoderAdapter::Release().
     VideoEncoder* encoder;
     EncodedImageCallback* callback;
     uint16_t width;
     uint16_t height;
     bool key_frame_request;
     bool send_stream;
   };
 
-  // Get the stream bitrate, for the stream |stream_idx|, given the bitrate
-  // |new_bitrate_kbit| and the actual configured stream count in
-  // |total_number_of_streams|. The function also returns whether there's enough
-  // bandwidth to send this stream via |send_stream|.
-  uint32_t GetStreamBitrate(int stream_idx,
-                            size_t total_number_of_streams,
-                            uint32_t new_bitrate_kbit,
-                            bool* send_stream) const;
-
-  // Populate the codec settings for each stream.
-  void PopulateStreamCodec(const webrtc::VideoCodec* inst,
-                           int stream_index,
-                           size_t total_number_of_streams,
-                           bool highest_resolution_stream,
-                           webrtc::VideoCodec* stream_codec,
-                           bool* send_stream);
-
   bool Initialized() const;
 
   std::unique_ptr<VideoEncoderFactory> factory_;
   std::unique_ptr<TemporalLayersFactory> screensharing_tl_factory_;
   VideoCodec codec_;
-  std::vector<StreamInfo> streaminfos_;
+  std::unique_ptr<SimulcastState> stream_states_;

[pbos-webrtc, 2016/04/29 21:23:27]

Can you stack allocate this (e.g. SimulcastState stream_states_) ?

You can still use copy constructors to reset it, right?

+  typedef std::pair<VideoEncoder*, std::unique_ptr<EncodedImageCallback>>
+      EncoderContext;
+  std::map<uint8_t, EncoderContext> encoders_;
   EncodedImageCallback* encoded_complete_callback_;
   std::string implementation_name_;
 };
 
 }  // namespace webrtc
 
 #endif  // WEBRTC_MODULES_VIDEO_CODING_CODECS_VP8_SIMULCAST_ENCODER_ADAPTER_H_