Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(791)

Issue 1913043003: Revert of Remove the rtc_relative_path GYP variable and similar defines (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Remove the rtc_relative_path GYP variable and similar defines (patchset #1 id:1 of https://codereview.webrtc.org/1903553003/ ) Reason for revert: Breaks downstream for SRTP include paths. Will rework this and reland without that one. Original issue's description: > Remove the rtc_relative_path GYP variable and similar defines > > The defines that can be used to alter the include paths for Expat, SRTP > and gtest are no longer needed in WebRTC or Chromium. Let's remove them > to simplify the GYP a little. > > Removed defines: > EXPAT_RELATIVE_PATH > GTEST_RELATIVE_PATH > SRTP_RELATIVE_PATH > > They're all set in the Chromium build so this shouldn't affect Chromium: > https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle.gyp > > BUG=webrtc:4256 > NOTRY=True > NOPRESUBMIT=True > > Committed: https://crrev.com/e19cf59eb6ee44fd4d7e7fbcfdd1a6ea75063605 > Cr-Commit-Position: refs/heads/master@{#12467} TBR=pthatcher@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:4256 Committed: https://crrev.com/7bc7c06e6ad2663e7bd766308b9fbe2fb3514337 Cr-Commit-Position: refs/heads/master@{#12468}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+54 lines, -1 line) Patch
M webrtc/base/base_tests.gyp View 1 chunk +8 lines, -0 lines 0 comments Download
M webrtc/base/gunit.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/base/gunit_prod.h View 1 chunk +4 lines, -1 line 0 comments Download
M webrtc/build/common.gypi View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/libjingle/xmllite/xmlbuilder.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/libjingle/xmllite/xmlparser.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppstanzaparser.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/pc/externalhmac.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/pc/externalhmac.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/pc/srtpfilter.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
kjellander_webrtc
Created Revert of Remove the rtc_relative_path GYP variable and similar defines
4 years, 8 months ago (2016-04-22 11:57:34 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1913043003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1913043003/1
4 years, 8 months ago (2016-04-22 11:57:45 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 11:57:53 UTC) #3
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 11:58:05 UTC) #5
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/7bc7c06e6ad2663e7bd766308b9fbe2fb3514337
Cr-Commit-Position: refs/heads/master@{#12468}

Powered by Google App Engine
This is Rietveld 408576698