Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

This is a first CL in a row of CLs to move everything related to
receiving RTP from ViEChanel to ViEReceiver, rename the classes and
move ViEReceiver ownership to VideoReceiveStream.

Committed: https://crrev.com/c0e58a3438c7bcedf9a197d232d1ca6a530ce15a
Cr-Commit-Position: refs/heads/master@{#12486}

[mflodman, 2016-04-22 12:37:49]

mflodman@webrtc.org changed reviewers:
+ pbos@webrtc.org

[mflodman, 2016-04-22 12:37:50]

Peter,
Please take a look.

[mflodman, 2016-04-22 13:04:54]

Description was changed from

==========
Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

This is a first CL in a row of CLs to move everything related to
receiving RTP from ViEChanel to ViEReceiver, rename the classes and
move ViEReceiver ownership to VideoReceiveStream.

The first follow up will be to get rid of rtp_rtcp() in ViEChannel.
==========

to

==========
Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

This is a first CL in a row of CLs to move everything related to
receiving RTP from ViEChanel to ViEReceiver, rename the classes and
move ViEReceiver ownership to VideoReceiveStream.
==========

[pbos-webrtc, 2016-04-22 15:16:58]

lgtm

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.cc:79:
module_process_thread_->RegisterModule(rtp_rtcp_);
As a follow-up maybe both of these should be done inside vie_receiver_?

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel.h
File webrtc/video/vie_channel.h (right):

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.h:75: RtpRtcp* rtp_rtcp() const { return
vie_receiver_.rtp_rtcp(); }
return rtp_rtcp_ right?

[mflodman, 2016-04-25 07:03:22]

Will submit, only minor change in since all try bots passed ps#1.

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel.cc
File webrtc/video/vie_channel.cc (right):

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.cc:79:
module_process_thread_->RegisterModule(rtp_rtcp_);
On 2016/04/22 15:16:58, pbos-webrtc wrote:
> As a follow-up maybe both of these should be done inside vie_receiver_?

Or rather when creating this in VideoReceiveStream, after breaking out
ViEReceiver from ViEChannel. But yes, agree.

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel.h
File webrtc/video/vie_channel.h (right):

https://codereview.webrtc.org/1912133002/diff/20001/webrtc/video/vie_channel....
webrtc/video/vie_channel.h:75: RtpRtcp* rtp_rtcp() const { return
vie_receiver_.rtp_rtcp(); }
On 2016/04/22 15:16:58, pbos-webrtc wrote:
> return rtp_rtcp_ right?

Done.

[mflodman, 2016-04-25 07:11:56]

Or not, since I had to rebase.

[mflodman, 2016-04-25 07:12:00]

The CQ bit was checked by mflodman@webrtc.org

[mflodman, 2016-04-25 07:12:00]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1912133002/#ps60001 (title:
"rebase")

[commit-bot: I haz the power, 2016-04-25 07:12:11]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912133002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912133002/60001

[commit-bot: I haz the power, 2016-04-25 07:14:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-25 07:14:04]

Try jobs failed on following builders:
  linux_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/linux_gn_rel/builds/10363)
  mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2613)
  mac_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_rel/builds/14550)
  win_x64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/win_x64_rel/builds/14181)

[mflodman, 2016-04-25 07:25:12]

The CQ bit was checked by mflodman@webrtc.org

[mflodman, 2016-04-25 07:25:12]

The patchset sent to the CQ was uploaded after l-g-t-m from pbos@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1912133002/#ps80001 (title:
"Rebase fix")

[commit-bot: I haz the power, 2016-04-25 07:25:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1912133002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1912133002/80001

[commit-bot: I haz the power, 2016-04-25 08:26:30]

Description was changed from

==========
Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

This is a first CL in a row of CLs to move everything related to
receiving RTP from ViEChanel to ViEReceiver, rename the classes and
move ViEReceiver ownership to VideoReceiveStream.
==========

to

==========
Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

This is a first CL in a row of CLs to move everything related to
receiving RTP from ViEChanel to ViEReceiver, rename the classes and
move ViEReceiver ownership to VideoReceiveStream.
==========

[commit-bot: I haz the power, 2016-04-25 08:26:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-25 08:26:36]

Description was changed from

==========
Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

This is a first CL in a row of CLs to move everything related to
receiving RTP from ViEChanel to ViEReceiver, rename the classes and
move ViEReceiver ownership to VideoReceiveStream.
==========

to

==========
Move receive RtpRtcp ownership from ViEChannel to ViEReceiver.

This is a first CL in a row of CLs to move everything related to
receiving RTP from ViEChanel to ViEReceiver, rename the classes and
move ViEReceiver ownership to VideoReceiveStream.

Committed: https://crrev.com/c0e58a3438c7bcedf9a197d232d1ca6a530ce15a
Cr-Commit-Position: refs/heads/master@{#12486}
==========

[commit-bot: I haz the power, 2016-04-25 08:26:37]

Patchset 5 (id:??) landed as
https://crrev.com/c0e58a3438c7bcedf9a197d232d1ca6a530ce15a
Cr-Commit-Position: refs/heads/master@{#12486}

[mflodman, 2016-04-29 07:49:11]

Patchset #6 (id:100001) has been deleted