Add last error to fatal error messages.

Add last error to fatal error messages.
This requires including logging.h, which in turn pointed out a problem with our 'LOG_TAG' macro, so that macro is now renamed.

BUG=

Committed: https://crrev.com/e8be6ff65def1d77409d57126915565b0208aee6
Cr-Commit-Position: refs/heads/master@{#12464}

[tommi, 2016-04-21 22:27:47]

tommi@webrtc.org changed reviewers:
+ perkj@webrtc.org

[tommi, 2016-04-21 22:27:54]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 22:27:59]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911903002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911903002/1

[commit-bot: I haz the power, 2016-04-22 00:25:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 00:25:15]

Dry run: This issue passed the CQ dry run.

[perkj_webrtc, 2016-04-22 05:17:30]

lgtm with the below addressed.

https://codereview.webrtc.org/1911903002/diff/1/webrtc/base/checks.cc
File webrtc/base/checks.cc (right):

https://codereview.webrtc.org/1911903002/diff/1/webrtc/base/checks.cc#newcode116
webrtc/base/checks.cc:116: << "# last error=" << LAST_SYSTEM_ERROR << std::endl
Suggest " last system error: " (or=)

It seems to be used for other things than just system problems.

[tommi, 2016-04-22 07:12:18]

Address comments

[tommi, 2016-04-22 07:12:24]

https://codereview.webrtc.org/1911903002/diff/1/webrtc/base/checks.cc
File webrtc/base/checks.cc (right):

https://codereview.webrtc.org/1911903002/diff/1/webrtc/base/checks.cc#newcode116
webrtc/base/checks.cc:116: << "# last error=" << LAST_SYSTEM_ERROR << std::endl
On 2016/04/22 05:17:30, perkj_webrtc wrote:
> Suggest " last system error: " (or=)
> 
> It seems to be used for other things than just system problems.

Done.

[tommi, 2016-04-22 07:12:36]

The CQ bit was checked by tommi@webrtc.org

[tommi, 2016-04-22 07:12:36]

The patchset sent to the CQ was uploaded after l-g-t-m from perkj@webrtc.org
Link to the patchset: https://codereview.webrtc.org/1911903002/#ps20001 (title:
"Address comments")

[commit-bot: I haz the power, 2016-04-22 07:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1911903002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1911903002/20001

[commit-bot: I haz the power, 2016-04-22 08:22:28]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-22 08:22:38]

Description was changed from

==========
Add last error to fatal error messages.
This requires including logging.h, which in turn pointed out a problem with our
'LOG_TAG' macro, so that macro is now renamed.

BUG=
==========

to

==========
Add last error to fatal error messages.
This requires including logging.h, which in turn pointed out a problem with our
'LOG_TAG' macro, so that macro is now renamed.

BUG=

Committed: https://crrev.com/e8be6ff65def1d77409d57126915565b0208aee6
Cr-Commit-Position: refs/heads/master@{#12464}
==========

[commit-bot: I haz the power, 2016-04-22 08:22:38]

Patchset 2 (id:??) landed as
https://crrev.com/e8be6ff65def1d77409d57126915565b0208aee6
Cr-Commit-Position: refs/heads/master@{#12464}