Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 1910633003: Update QuicTransportChannel to latest version of libquic (Chromium: f03d2c62) (Closed)

Created:
4 years, 8 months ago by mikescarlett
Modified:
4 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Update QuicTransportChannel to latest version of libquic (Chromium: f03d2c62) These changes are necessary to incorporate the latest changes to QUIC sessions and the QUIC crypto handshake. BUG= Committed: https://crrev.com/8d37d2941ea48e20dd27a6add21d25b1f6b3d050 Cr-Commit-Position: refs/heads/master@{#12571}

Patch Set 1 #

Patch Set 2 : Sync to upstream #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -29 lines) Patch
M webrtc/p2p/quic/quicconnectionhelper_unittest.cc View 1 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/p2p/quic/quicsession.h View 1 2 chunks +3 lines, -1 line 0 comments Download
M webrtc/p2p/quic/quicsession.cc View 1 3 chunks +12 lines, -11 lines 0 comments Download
M webrtc/p2p/quic/quicsession_unittest.cc View 1 6 chunks +16 lines, -5 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.h View 1 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/p2p/quic/quictransportchannel.cc View 1 2 chunks +10 lines, -1 line 0 comments Download
M webrtc/p2p/quic/reliablequicstream_unittest.cc View 1 3 chunks +5 lines, -7 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
mikescarlett
4 years, 8 months ago (2016-04-20 21:30:19 UTC) #4
mikescarlett
Hi Peter, Please review this CL before my other CLs. I updated the libquic library ...
4 years, 8 months ago (2016-04-25 17:25:35 UTC) #6
pthatcher1
lgtm
4 years, 7 months ago (2016-04-29 19:29:53 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910633003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910633003/1
4 years, 7 months ago (2016-04-29 20:07:22 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_gn_dbg on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/android_gn_dbg/builds/10660) android_gn_rel on tryserver.webrtc (JOB_FAILED, ...
4 years, 7 months ago (2016-04-29 20:08:33 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910633003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910633003/20001
4 years, 7 months ago (2016-04-29 21:08:04 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 7 months ago (2016-04-29 22:35:04 UTC) #16
commit-bot: I haz the power
4 years, 7 months ago (2016-05-01 22:02:13 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8d37d2941ea48e20dd27a6add21d25b1f6b3d050
Cr-Commit-Position: refs/heads/master@{#12571}

Powered by Google App Engine
This is Rietveld 408576698