Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(886)

Issue 1910203002: Revert of Modify ScreenCaptureFrameQueue into a template (Closed)

Created:
4 years, 8 months ago by torbjorng
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Revert of Modify ScreenCaptureFrameQueue into a template (patchset #10 id:170001 of https://codereview.webrtc.org/1902323002/ ) Reason for revert: Breaks FYI bits, e.g. this one: https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win%20Builder/builds/4430 Original issue's description: > Modify ScreenCaptureFrameQueue into a template > > BUG= > > Committed: https://crrev.com/34cad48cfbd362ae0c9027365550bfe28e2e10ef > Cr-Commit-Position: refs/heads/master@{#12458} TBR=sergeyu@chromium.org,zijiehe@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/1bcb8f05ad9da00ed6ea579381c8197be3188f32 Cr-Commit-Position: refs/heads/master@{#12459}

Patch Set 1 #

Messages

Total messages: 11 (4 generated)
torbjorng
Created Revert of Modify ScreenCaptureFrameQueue into a template
4 years, 8 months ago (2016-04-21 21:07:06 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910203002/1
4 years, 8 months ago (2016-04-21 21:07:12 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 8 months ago (2016-04-21 21:07:15 UTC) #4
torbjorng (webrtc)
lgtm
4 years, 8 months ago (2016-04-21 21:17:47 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1910203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1910203002/1
4 years, 8 months ago (2016-04-21 21:18:12 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-21 21:18:23 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 21:18:32 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1bcb8f05ad9da00ed6ea579381c8197be3188f32
Cr-Commit-Position: refs/heads/master@{#12459}

Powered by Google App Engine
This is Rietveld 408576698