Switch voice transport to use Call and Stream instead of VoENetwork.

webrtc/voice_engine/channel_proxy.cc

 /*
  *  Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
  *
  *  Use of this source code is governed by a BSD-style license
  *  that can be found in the LICENSE file in the root of the source
  *  tree. An additional intellectual property rights grant can be found
  *  in the file PATENTS.  All contributing project authors may
  *  be found in the AUTHORS file in the root of the source tree.
  */
 
@@ skipping 140 matching lines @@
 bool ChannelProxy::SendTelephoneEventOutband(int event, int duration_ms) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   return channel()->SendTelephoneEventOutband(event, duration_ms) == 0;
 }
 
 void ChannelProxy::SetSink(std::unique_ptr<AudioSinkInterface> sink) {
   RTC_DCHECK(thread_checker_.CalledOnValidThread());
   channel()->SetSink(std::move(sink));
 }
 
+void ChannelProxy::RegisterExternalTransport(Transport* transport) {

[the sun, 2016/04/22 12:40:32]

Add:
RTC_DCHECK(thread_checker_.CalledOnValidThread());

[mflodman, 2016/04/27 13:42:18]

Done.

+  channel()->RegisterExternalTransport(*transport);

[the sun, 2016/04/22 12:40:32]

Change Channel::RegisterExternalTransport() to take a Transport* instead. Looks
like the code in Channel will work if we supply a nullptr without fuss, and we
don't crash on the deref here.

Also, add 
int error = ...
RTC_DCHECK_EQ(0, error);
(here and below)

[mflodman, 2016/04/27 13:42:18]

Done. And agree is should be safe, but the logic could be optimized there since
I assume we're always using external transport.

+}
+
+void ChannelProxy::DeRegisterExternalTransport() {

[the sun, 2016/04/22 12:40:32]

Add:
RTC_DCHECK(thread_checker_.CalledOnValidThread());

[mflodman, 2016/04/27 13:42:18]

Done.

+  channel()->DeRegisterExternalTransport();
+}
+
+bool ChannelProxy::ReceivedRTPPacket(const uint8_t* packet,
+                                     size_t length,
+                                     const PacketTime& packet_time) {

[the sun, 2016/04/22 12:40:32]

Add:
// May be called on either worker thread or network thread.
(and below)

[mflodman, 2016/04/27 13:42:18]

Done.

+  return channel()->ReceivedRTPPacket(packet, length, packet_time) == 0;
+}
+
+bool ChannelProxy::ReceivedRTCPPacket(const uint8_t* packet, size_t length) {
+  return channel()->ReceivedRTCPPacket(packet, length) == 0;
+}
+
 Channel* ChannelProxy::channel() const {
   RTC_DCHECK(channel_owner_.channel());
   return channel_owner_.channel();
 }
 
 }  // namespace voe
 }  // namespace webrtc