Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Side by Side Diff: webrtc/audio/audio_receive_stream_unittest.cc

Issue 1909333002: Switch voice transport to use Call and Stream instead of VoENetwork. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed coments on ps#6 Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « webrtc/audio/audio_receive_stream.cc ('k') | webrtc/audio/audio_send_stream.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2015 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 EXPECT_CALL(*channel_proxy_, EnableReceiveTransportSequenceNumber( 91 EXPECT_CALL(*channel_proxy_, EnableReceiveTransportSequenceNumber(
92 kTransportSequenceNumberId)) 92 kTransportSequenceNumberId))
93 .Times(1); 93 .Times(1);
94 EXPECT_CALL(*channel_proxy_, 94 EXPECT_CALL(*channel_proxy_,
95 RegisterReceiverCongestionControlObjects(&packet_router_)) 95 RegisterReceiverCongestionControlObjects(&packet_router_))
96 .Times(1); 96 .Times(1);
97 EXPECT_CALL(congestion_controller_, packet_router()) 97 EXPECT_CALL(congestion_controller_, packet_router())
98 .WillOnce(Return(&packet_router_)); 98 .WillOnce(Return(&packet_router_));
99 EXPECT_CALL(*channel_proxy_, ResetCongestionControlObjects()) 99 EXPECT_CALL(*channel_proxy_, ResetCongestionControlObjects())
100 .Times(1); 100 .Times(1);
101 EXPECT_CALL(*channel_proxy_, RegisterExternalTransport(nullptr))
102 .Times(1);
103 EXPECT_CALL(*channel_proxy_, DeRegisterExternalTransport())
104 .Times(1);
101 return channel_proxy_; 105 return channel_proxy_;
102 })); 106 }));
103 stream_config_.voe_channel_id = kChannelId; 107 stream_config_.voe_channel_id = kChannelId;
104 stream_config_.rtp.local_ssrc = kLocalSsrc; 108 stream_config_.rtp.local_ssrc = kLocalSsrc;
105 stream_config_.rtp.remote_ssrc = kRemoteSsrc; 109 stream_config_.rtp.remote_ssrc = kRemoteSsrc;
106 stream_config_.rtp.extensions.push_back( 110 stream_config_.rtp.extensions.push_back(
107 RtpExtension(RtpExtension::kAbsSendTime, kAbsSendTimeId)); 111 RtpExtension(RtpExtension::kAbsSendTime, kAbsSendTimeId));
108 stream_config_.rtp.extensions.push_back( 112 stream_config_.rtp.extensions.push_back(
109 RtpExtension(RtpExtension::kAudioLevel, kAudioLevelId)); 113 RtpExtension(RtpExtension::kAudioLevel, kAudioLevelId));
110 stream_config_.rtp.extensions.push_back(RtpExtension( 114 stream_config_.rtp.extensions.push_back(RtpExtension(
111 RtpExtension::kTransportSequenceNumber, kTransportSequenceNumberId)); 115 RtpExtension::kTransportSequenceNumber, kTransportSequenceNumberId));
112 } 116 }
113 117
114 MockCongestionController* congestion_controller() { 118 MockCongestionController* congestion_controller() {
115 return &congestion_controller_; 119 return &congestion_controller_;
116 } 120 }
117 MockRemoteBitrateEstimator* remote_bitrate_estimator() { 121 MockRemoteBitrateEstimator* remote_bitrate_estimator() {
118 return &remote_bitrate_estimator_; 122 return &remote_bitrate_estimator_;
119 } 123 }
120 AudioReceiveStream::Config& config() { return stream_config_; } 124 AudioReceiveStream::Config& config() { return stream_config_; }
121 rtc::scoped_refptr<AudioState> audio_state() { return audio_state_; } 125 rtc::scoped_refptr<AudioState> audio_state() { return audio_state_; }
122 MockVoiceEngine& voice_engine() { return voice_engine_; } 126 MockVoiceEngine& voice_engine() { return voice_engine_; }
127 MockVoEChannelProxy* channel_proxy() { return channel_proxy_; }
123 128
124 void SetupMockForBweFeedback(bool send_side_bwe) { 129 void SetupMockForBweFeedback(bool send_side_bwe) {
125 EXPECT_CALL(congestion_controller_, 130 EXPECT_CALL(congestion_controller_,
126 GetRemoteBitrateEstimator(send_side_bwe)) 131 GetRemoteBitrateEstimator(send_side_bwe))
127 .WillOnce(Return(&remote_bitrate_estimator_)); 132 .WillOnce(Return(&remote_bitrate_estimator_));
128 EXPECT_CALL(remote_bitrate_estimator_, 133 EXPECT_CALL(remote_bitrate_estimator_,
129 RemoveStream(stream_config_.rtp.remote_ssrc)); 134 RemoveStream(stream_config_.rtp.remote_ssrc));
130 } 135 }
131 136
132 void SetupMockForGetStats() { 137 void SetupMockForGetStats() {
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
174 it += 2; 179 it += 2;
175 const size_t kExtensionDataLength = kOneByteExtensionLength - 1; 180 const size_t kExtensionDataLength = kOneByteExtensionLength - 1;
176 uint32_t shifted_value = extension_value 181 uint32_t shifted_value = extension_value
177 << (8 * (kExtensionDataLength - value_length)); 182 << (8 * (kExtensionDataLength - value_length));
178 *it = (id << 4) + (value_length - 1); 183 *it = (id << 4) + (value_length - 1);
179 ++it; 184 ++it;
180 ByteWriter<uint32_t, kExtensionDataLength>::WriteBigEndian(&(*it), 185 ByteWriter<uint32_t, kExtensionDataLength>::WriteBigEndian(&(*it),
181 shifted_value); 186 shifted_value);
182 } 187 }
183 188
184 std::vector<uint8_t> CreateRtpHeaderWithOneByteExtension( 189 const std::vector<uint8_t> CreateRtpHeaderWithOneByteExtension(
185 int extension_id, 190 int extension_id,
186 uint32_t extension_value, 191 uint32_t extension_value,
187 size_t value_length) { 192 size_t value_length) {
188 std::vector<uint8_t> header; 193 std::vector<uint8_t> header;
189 header.resize(webrtc::kRtpHeaderSize + kOneByteExtensionHeaderLength + 194 header.resize(webrtc::kRtpHeaderSize + kOneByteExtensionHeaderLength +
190 kOneByteExtensionLength); 195 kOneByteExtensionLength);
191 header[0] = 0x80; // Version 2. 196 header[0] = 0x80; // Version 2.
192 header[0] |= 0x10; // Set extension bit. 197 header[0] |= 0x10; // Set extension bit.
193 header[1] = 100; // Payload type. 198 header[1] = 100; // Payload type.
194 header[1] |= 0x80; // Marker bit is set. 199 header[1] |= 0x80; // Marker bit is set.
195 ByteWriter<uint16_t>::WriteBigEndian(&header[2], 0x1234); // Sequence number. 200 ByteWriter<uint16_t>::WriteBigEndian(&header[2], 0x1234); // Sequence number.
196 ByteWriter<uint32_t>::WriteBigEndian(&header[4], 0x5678); // Timestamp. 201 ByteWriter<uint32_t>::WriteBigEndian(&header[4], 0x5678); // Timestamp.
197 ByteWriter<uint32_t>::WriteBigEndian(&header[8], 0x4321); // SSRC. 202 ByteWriter<uint32_t>::WriteBigEndian(&header[8], 0x4321); // SSRC.
198 203
199 BuildOneByteExtension(header.begin() + webrtc::kRtpHeaderSize, extension_id, 204 BuildOneByteExtension(header.begin() + webrtc::kRtpHeaderSize, extension_id,
200 extension_value, value_length); 205 extension_value, value_length);
201 return header; 206 return header;
202 } 207 }
208
209 const std::vector<uint8_t> CreateRtcpSenderReport() {
210 std::vector<uint8_t> packet;
211 const size_t kRtcpSrLength = 28; // In bytes.
212 packet.resize(kRtcpSrLength);
213 packet[0] = 0x80; // Version 2.
214 packet[1] = 0xc8; // PT = 200, SR.
215 // Length in number of 32-bit words - 1.
216 ByteWriter<uint16_t>::WriteBigEndian(&packet[2], 6);
217 ByteWriter<uint32_t>::WriteBigEndian(&packet[4], kLocalSsrc);
218 return packet;
219 }
203 } // namespace 220 } // namespace
204 221
205 TEST(AudioReceiveStreamTest, ConfigToString) { 222 TEST(AudioReceiveStreamTest, ConfigToString) {
206 AudioReceiveStream::Config config; 223 AudioReceiveStream::Config config;
207 config.rtp.remote_ssrc = kRemoteSsrc; 224 config.rtp.remote_ssrc = kRemoteSsrc;
208 config.rtp.local_ssrc = kLocalSsrc; 225 config.rtp.local_ssrc = kLocalSsrc;
209 config.rtp.extensions.push_back( 226 config.rtp.extensions.push_back(
210 RtpExtension(RtpExtension::kAbsSendTime, kAbsSendTimeId)); 227 RtpExtension(RtpExtension::kAbsSendTime, kAbsSendTimeId));
211 config.voe_channel_id = kChannelId; 228 config.voe_channel_id = kChannelId;
212 EXPECT_EQ( 229 EXPECT_EQ(
213 "{rtp: {remote_ssrc: 1234, local_ssrc: 5678, extensions: [{name: " 230 "{rtp: {remote_ssrc: 1234, local_ssrc: 5678, extensions: [{name: "
214 "http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time, id: 2}], " 231 "http://www.webrtc.org/experiments/rtp-hdrext/abs-send-time, id: 2}], "
215 "transport_cc: off}, " 232 "transport_cc: off}, "
216 "receive_transport: nullptr, rtcp_send_transport: nullptr, " 233 "rtcp_send_transport: nullptr, "
217 "voe_channel_id: 2}", 234 "voe_channel_id: 2}",
218 config.ToString()); 235 config.ToString());
219 } 236 }
220 237
221 TEST(AudioReceiveStreamTest, ConstructDestruct) { 238 TEST(AudioReceiveStreamTest, ConstructDestruct) {
222 ConfigHelper helper; 239 ConfigHelper helper;
223 internal::AudioReceiveStream recv_stream( 240 internal::AudioReceiveStream recv_stream(
224 helper.congestion_controller(), helper.config(), helper.audio_state()); 241 helper.congestion_controller(), helper.config(), helper.audio_state());
225 } 242 }
226 243
227 MATCHER_P(VerifyHeaderExtension, expected_extension, "") { 244 MATCHER_P(VerifyHeaderExtension, expected_extension, "") {
228 return arg.extension.hasAbsoluteSendTime == 245 return arg.extension.hasAbsoluteSendTime ==
229 expected_extension.hasAbsoluteSendTime && 246 expected_extension.hasAbsoluteSendTime &&
230 arg.extension.absoluteSendTime == 247 arg.extension.absoluteSendTime ==
231 expected_extension.absoluteSendTime && 248 expected_extension.absoluteSendTime &&
232 arg.extension.hasTransportSequenceNumber == 249 arg.extension.hasTransportSequenceNumber ==
233 expected_extension.hasTransportSequenceNumber && 250 expected_extension.hasTransportSequenceNumber &&
234 arg.extension.transportSequenceNumber == 251 arg.extension.transportSequenceNumber ==
235 expected_extension.transportSequenceNumber; 252 expected_extension.transportSequenceNumber;
236 } 253 }
237 254
238 TEST(AudioReceiveStreamTest, AudioPacketUpdatesBweFeedback) { 255 TEST(AudioReceiveStreamTest, ReceiveRtpPacket) {
239 ConfigHelper helper; 256 ConfigHelper helper;
240 helper.config().rtp.transport_cc = true; 257 helper.config().rtp.transport_cc = true;
241 helper.SetupMockForBweFeedback(true); 258 helper.SetupMockForBweFeedback(true);
242 internal::AudioReceiveStream recv_stream( 259 internal::AudioReceiveStream recv_stream(
243 helper.congestion_controller(), helper.config(), helper.audio_state()); 260 helper.congestion_controller(), helper.config(), helper.audio_state());
244 const int kTransportSequenceNumberValue = 1234; 261 const int kTransportSequenceNumberValue = 1234;
245 std::vector<uint8_t> rtp_packet = CreateRtpHeaderWithOneByteExtension( 262 std::vector<uint8_t> rtp_packet = CreateRtpHeaderWithOneByteExtension(
246 kTransportSequenceNumberId, kTransportSequenceNumberValue, 2); 263 kTransportSequenceNumberId, kTransportSequenceNumberValue, 2);
247 PacketTime packet_time(5678000, 0); 264 PacketTime packet_time(5678000, 0);
248 const size_t kExpectedHeaderLength = 20; 265 const size_t kExpectedHeaderLength = 20;
249 RTPHeaderExtension expected_extension; 266 RTPHeaderExtension expected_extension;
250 expected_extension.hasTransportSequenceNumber = true; 267 expected_extension.hasTransportSequenceNumber = true;
251 expected_extension.transportSequenceNumber = kTransportSequenceNumberValue; 268 expected_extension.transportSequenceNumber = kTransportSequenceNumberValue;
252 EXPECT_CALL(*helper.remote_bitrate_estimator(), 269 EXPECT_CALL(*helper.remote_bitrate_estimator(),
253 IncomingPacket(packet_time.timestamp / 1000, 270 IncomingPacket(packet_time.timestamp / 1000,
254 rtp_packet.size() - kExpectedHeaderLength, 271 rtp_packet.size() - kExpectedHeaderLength,
255 VerifyHeaderExtension(expected_extension), false)) 272 VerifyHeaderExtension(expected_extension), false))
256 .Times(1); 273 .Times(1);
274 EXPECT_CALL(*helper.channel_proxy(),
275 ReceivedRTPPacket(&rtp_packet[0],
276 rtp_packet.size(),
277 _))
278 .WillOnce(Return(true));
257 EXPECT_TRUE( 279 EXPECT_TRUE(
258 recv_stream.DeliverRtp(&rtp_packet[0], rtp_packet.size(), packet_time)); 280 recv_stream.DeliverRtp(&rtp_packet[0], rtp_packet.size(), packet_time));
259 } 281 }
260 282
283 TEST(AudioReceiveStreamTest, ReceiveRtcpPacket) {
284 ConfigHelper helper;
285 helper.config().rtp.transport_cc = true;
286 helper.SetupMockForBweFeedback(true);
287 internal::AudioReceiveStream recv_stream(
288 helper.congestion_controller(), helper.config(), helper.audio_state());
289
290 std::vector<uint8_t> rtcp_packet = CreateRtcpSenderReport();
291 EXPECT_CALL(*helper.channel_proxy(),
292 ReceivedRTCPPacket(&rtcp_packet[0], rtcp_packet.size()))
293 .WillOnce(Return(true));
294 EXPECT_TRUE(recv_stream.DeliverRtcp(&rtcp_packet[0], rtcp_packet.size()));
295 }
296
297
261 TEST(AudioReceiveStreamTest, GetStats) { 298 TEST(AudioReceiveStreamTest, GetStats) {
262 ConfigHelper helper; 299 ConfigHelper helper;
263 internal::AudioReceiveStream recv_stream( 300 internal::AudioReceiveStream recv_stream(
264 helper.congestion_controller(), helper.config(), helper.audio_state()); 301 helper.congestion_controller(), helper.config(), helper.audio_state());
265 helper.SetupMockForGetStats(); 302 helper.SetupMockForGetStats();
266 AudioReceiveStream::Stats stats = recv_stream.GetStats(); 303 AudioReceiveStream::Stats stats = recv_stream.GetStats();
267 EXPECT_EQ(kRemoteSsrc, stats.remote_ssrc); 304 EXPECT_EQ(kRemoteSsrc, stats.remote_ssrc);
268 EXPECT_EQ(static_cast<int64_t>(kCallStats.bytesReceived), stats.bytes_rcvd); 305 EXPECT_EQ(static_cast<int64_t>(kCallStats.bytesReceived), stats.bytes_rcvd);
269 EXPECT_EQ(static_cast<uint32_t>(kCallStats.packetsReceived), 306 EXPECT_EQ(static_cast<uint32_t>(kCallStats.packetsReceived),
270 stats.packets_rcvd); 307 stats.packets_rcvd);
(...skipping 23 matching lines...) Expand all
294 EXPECT_EQ(kAudioDecodeStats.calls_to_neteq, stats.decoding_calls_to_neteq); 331 EXPECT_EQ(kAudioDecodeStats.calls_to_neteq, stats.decoding_calls_to_neteq);
295 EXPECT_EQ(kAudioDecodeStats.decoded_normal, stats.decoding_normal); 332 EXPECT_EQ(kAudioDecodeStats.decoded_normal, stats.decoding_normal);
296 EXPECT_EQ(kAudioDecodeStats.decoded_plc, stats.decoding_plc); 333 EXPECT_EQ(kAudioDecodeStats.decoded_plc, stats.decoding_plc);
297 EXPECT_EQ(kAudioDecodeStats.decoded_cng, stats.decoding_cng); 334 EXPECT_EQ(kAudioDecodeStats.decoded_cng, stats.decoding_cng);
298 EXPECT_EQ(kAudioDecodeStats.decoded_plc_cng, stats.decoding_plc_cng); 335 EXPECT_EQ(kAudioDecodeStats.decoded_plc_cng, stats.decoding_plc_cng);
299 EXPECT_EQ(kCallStats.capture_start_ntp_time_ms_, 336 EXPECT_EQ(kCallStats.capture_start_ntp_time_ms_,
300 stats.capture_start_ntp_time_ms); 337 stats.capture_start_ntp_time_ms);
301 } 338 }
302 } // namespace test 339 } // namespace test
303 } // namespace webrtc 340 } // namespace webrtc
OLDNEW
« no previous file with comments | « webrtc/audio/audio_receive_stream.cc ('k') | webrtc/audio/audio_send_stream.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698