Add links for base/third_party/libevent from Chrome.

Add links for base/third_party/libevent from Chrome.
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm wondering if that's really the best way to do this for WebRTC as well.

NOTRY=True

Committed: https://crrev.com/de3b02916e63651130ddf7d1af98ef88753c6013
Cr-Commit-Position: refs/heads/master@{#12465}

[tommi, 2016-04-21 22:20:30]

tommi@webrtc.org changed reviewers:
+ kjellander@webrtc.org

[tommi, 2016-04-21 22:20:41]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 22:20:50]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909223004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909223004/1

[commit-bot: I haz the power, 2016-04-21 22:22:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:22:40]

Dry run: Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/12708)

[tommi, 2016-04-21 22:29:44]

On 2016/04/21 22:22:40, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   android_rel on tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/12708)

Henrik - looks like there are problems with that folder indeed.  I'm not sure
what the script is actually trying to do (some bots fail with 'file exists',
others with 'file doesn't exist'), can you advice?

[tommi, 2016-04-21 22:30:14]

On 2016/04/21 22:29:44, tommi-webrtc wrote:
> On 2016/04/21 22:22:40, commit-bot: I haz the power wrote:
> > Dry run: Try jobs failed on following builders:
> >   android_rel on tryserver.webrtc (JOB_FAILED,
> >
>
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/12708)
> 
> Henrik - looks like there are problems with that folder indeed.  I'm not sure
> what the script is actually trying to do (some bots fail with 'file exists',
> others with 'file doesn't exist'), can you advice?

and the problem is only on android... (alas libevent is needed there).

[tommi, 2016-04-21 22:33:44]

update the DEPS file as well

[tommi, 2016-04-21 22:34:54]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-21 22:35:06]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909223004/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909223004/20001

[commit-bot: I haz the power, 2016-04-21 22:41:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-21 22:41:17]

Dry run: Try jobs failed on following builders:
  android_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_rel/builds/12712)

[kjellander_webrtc, 2016-04-22 06:32:27]

https://codereview.webrtc.org/1909223004/diff/20001/setup_links.py
File setup_links.py (right):

https://codereview.webrtc.org/1909223004/diff/20001/setup_links.py#newcode32
setup_links.py:32: 'base/third_party/libevent',
There's already a 'base' link for Android below. So you'll have to move that up
here instead (and with that we'll get it for all platforms, which I guess it
unavoidable if we're going to depend on this).

[tommi, 2016-04-22 07:09:59]

Move base up

[tommi, 2016-04-22 07:10:21]

https://codereview.webrtc.org/1909223004/diff/20001/setup_links.py
File setup_links.py (right):

https://codereview.webrtc.org/1909223004/diff/20001/setup_links.py#newcode32
setup_links.py:32: 'base/third_party/libevent',
On 2016/04/22 06:32:27, kjellander (webrtc) wrote:
> There's already a 'base' link for Android below. So you'll have to move that
up
> here instead (and with that we'll get it for all platforms, which I guess it
> unavoidable if we're going to depend on this).

Ah, thanks!  Yeah, having a third_party directory in base is kinda strange :/

[tommi, 2016-04-22 07:10:29]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 07:10:32]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909223004/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909223004/40001

[commit-bot: I haz the power, 2016-04-22 07:11:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 07:11:44]

Dry run: Try jobs failed on following builders:
  ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/9215)
  ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/9137)
  mac_asan on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/14046)
  mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2536)
  mac_gn_rel on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/8765)

[tommi, 2016-04-22 07:17:37]

On 2016/04/22 07:11:44, commit-bot: I haz the power wrote:
> Dry run: Try jobs failed on following builders:
>   ios_arm64_dbg on tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_dbg/builds/9215)
>   ios_arm64_rel on tryserver.webrtc (JOB_FAILED,
>
http://build.chromium.org/p/tryserver.webrtc/builders/ios_arm64_rel/builds/9137)
>   mac_asan on tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/mac_asan/builds/14046)
>   mac_gn_dbg on tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_dbg/builds/2536)
>   mac_gn_rel on tryserver.webrtc (JOB_FAILED,
> http://build.chromium.org/p/tryserver.webrtc/builders/mac_gn_rel/builds/8765)

gaa... removing 'base' doesn't sound good :/  Do you know why android needs
base?

[tommi, 2016-04-22 07:20:35]

Try removing base

[tommi, 2016-04-22 07:20:57]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 07:21:03]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909223004/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909223004/60001

[commit-bot: I haz the power, 2016-04-22 07:23:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 07:23:56]

Dry run: Try jobs failed on following builders:
  android_compile_x86_dbg on tryserver.webrtc (JOB_FAILED,
http://build.chromium.org/p/tryserver.webrtc/builders/android_compile_x86_dbg...)

[tommi, 2016-04-22 07:31:36]

One more try

[tommi, 2016-04-22 07:32:00]

The CQ bit was checked by tommi@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-22 07:32:08]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909223004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909223004/80001

[kjellander_webrtc, 2016-04-22 07:54:40]

lgtm if trybots are happy.
Please try to use NOTRY=True on CLs like this, since we have scarce trybot
resources.

Also consider using an alias like this to run only compile trybots: lias
trycompile='git cl try --bot=win_x64_gn_rel --bot=win_x64_gn_dbg
--bot=win_x64_clang_rel --bot=win_x64_clang_dbg --bot=win_compile_x64_rel
--bot=win_compile_rel --bot=win_compile_dbg --bot=win_compile_x64_dbg
--bot=win_clang_rel --bot=mac_gn_rel --bot=mac_gn_dbg --bot=win_clang_dbg
--bot=linux_gn_rel --bot=mac_compile_dbg --bot=mac_compile_rel
--bot=linux_compile_rel --bot=linux_gn_dbg --bot=ios_rel --bot=linux_compile_dbg
--bot=ios_arm64_dbg --bot=ios_arm64_rel --bot=ios_dbg --bot=ios64_sim_dbg
--bot=ios32_sim_dbg --bot=android_gn_rel --bot=android_gn_dbg
--bot=android_compile_x86_dbg --bot=android_compile_x64_dbg
--bot=android_compile_dbg --bot=android_compile_arm64_rel
--bot=android_compile_rel --bot=android_compile_arm64_dbg
--bot=android_clang_dbg -m tryserver.webrtc'

https://codereview.webrtc.org/1909223004/diff/80001/setup_links.py
File setup_links.py (right):

https://codereview.webrtc.org/1909223004/diff/80001/setup_links.py#newcode109
setup_links.py:109: 'base/third_party/libevent',
This should work.

[tommi, 2016-04-22 08:02:16]

On 2016/04/22 07:54:40, kjellander (webrtc) wrote:
> lgtm if trybots are happy.
> Please try to use NOTRY=True on CLs like this, since we have scarce trybot
> resources.
> 
> Also consider using an alias like this to run only compile trybots: lias
> trycompile='git cl try --bot=win_x64_gn_rel --bot=win_x64_gn_dbg
> --bot=win_x64_clang_rel --bot=win_x64_clang_dbg --bot=win_compile_x64_rel
> --bot=win_compile_rel --bot=win_compile_dbg --bot=win_compile_x64_dbg
> --bot=win_clang_rel --bot=mac_gn_rel --bot=mac_gn_dbg --bot=win_clang_dbg
> --bot=linux_gn_rel --bot=mac_compile_dbg --bot=mac_compile_rel
> --bot=linux_compile_rel --bot=linux_gn_dbg --bot=ios_rel
--bot=linux_compile_dbg
> --bot=ios_arm64_dbg --bot=ios_arm64_rel --bot=ios_dbg --bot=ios64_sim_dbg
> --bot=ios32_sim_dbg --bot=android_gn_rel --bot=android_gn_dbg
> --bot=android_compile_x86_dbg --bot=android_compile_x64_dbg
> --bot=android_compile_dbg --bot=android_compile_arm64_rel
> --bot=android_compile_rel --bot=android_compile_arm64_dbg
> --bot=android_clang_dbg -m tryserver.webrtc'

Will do.  Btw I wish there was an easy way to cancel try jobs, even for a given
patch set.  I'd love it if I could do:

git cl upload -m "My new patchset" --cancel-previous-tryjobs
or
git cl try --cancel-running-tryjobs

> 
> https://codereview.webrtc.org/1909223004/diff/80001/setup_links.py
> File setup_links.py (right):
> 
> https://codereview.webrtc.org/1909223004/diff/80001/setup_links.py#newcode109
> setup_links.py:109: 'base/third_party/libevent',
> This should work.

Looks like it! :D

[tommi, 2016-04-22 08:02:47]

Description was changed from

==========
Add links for base/third_party/libevent from Chrome.
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm
wondering if that's really the best way to do this for WebRTC as well.

BUG=
==========

to

==========
Add links for base/third_party/libevent from Chrome.
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm
wondering if that's really the best way to do this for WebRTC as well.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-04-22 08:32:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-22 08:32:08]

Dry run: This issue passed the CQ dry run.

[tommi, 2016-04-22 08:43:55]

The CQ bit was checked by tommi@webrtc.org

[commit-bot: I haz the power, 2016-04-22 08:44:07]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1909223004/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1909223004/80001

[commit-bot: I haz the power, 2016-04-22 08:47:07]

Description was changed from

==========
Add links for base/third_party/libevent from Chrome.
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm
wondering if that's really the best way to do this for WebRTC as well.

NOTRY=True
==========

to

==========
Add links for base/third_party/libevent from Chrome.
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm
wondering if that's really the best way to do this for WebRTC as well.

NOTRY=True
==========

[commit-bot: I haz the power, 2016-04-22 08:47:08]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-22 08:47:18]

Description was changed from

==========
Add links for base/third_party/libevent from Chrome.
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm
wondering if that's really the best way to do this for WebRTC as well.

NOTRY=True
==========

to

==========
Add links for base/third_party/libevent from Chrome.
This is needed for an upcoming task queue implementation.
The location of this folder was recently moved under base/ in Chromium, so I'm
wondering if that's really the best way to do this for WebRTC as well.

NOTRY=True

Committed: https://crrev.com/de3b02916e63651130ddf7d1af98ef88753c6013
Cr-Commit-Position: refs/heads/master@{#12465}
==========

[commit-bot: I haz the power, 2016-04-22 08:47:19]

Patchset 5 (id:??) landed as
https://crrev.com/de3b02916e63651130ddf7d1af98ef88753c6013
Cr-Commit-Position: refs/heads/master@{#12465}

[kjellander_webrtc, 2016-04-22 08:58:58]

On 2016/04/22 08:02:16, tommi-webrtc wrote:
> On 2016/04/22 07:54:40, kjellander (webrtc) wrote:
> > lgtm if trybots are happy.
> > Please try to use NOTRY=True on CLs like this, since we have scarce trybot
> > resources.
> > 
> > Also consider using an alias like this to run only compile trybots: lias
> > trycompile='git cl try --bot=win_x64_gn_rel --bot=win_x64_gn_dbg
> > --bot=win_x64_clang_rel --bot=win_x64_clang_dbg --bot=win_compile_x64_rel
> > --bot=win_compile_rel --bot=win_compile_dbg --bot=win_compile_x64_dbg
> > --bot=win_clang_rel --bot=mac_gn_rel --bot=mac_gn_dbg --bot=win_clang_dbg
> > --bot=linux_gn_rel --bot=mac_compile_dbg --bot=mac_compile_rel
> > --bot=linux_compile_rel --bot=linux_gn_dbg --bot=ios_rel
> --bot=linux_compile_dbg
> > --bot=ios_arm64_dbg --bot=ios_arm64_rel --bot=ios_dbg --bot=ios64_sim_dbg
> > --bot=ios32_sim_dbg --bot=android_gn_rel --bot=android_gn_dbg
> > --bot=android_compile_x86_dbg --bot=android_compile_x64_dbg
> > --bot=android_compile_dbg --bot=android_compile_arm64_rel
> > --bot=android_compile_rel --bot=android_compile_arm64_dbg
> > --bot=android_clang_dbg -m tryserver.webrtc'
> 
> Will do.  Btw I wish there was an easy way to cancel try jobs, even for a
given
> patch set.  I'd love it if I could do:
> 
> git cl upload -m "My new patchset" --cancel-previous-tryjobs
> or
> git cl try --cancel-running-tryjobs

You're not alone, that's a request that pops up every now and then for Chrome
infra. I don't believe it's going to be implemented however - moving our trybots
over to swarming would be the better option, since then all tests with similar
hash signatures that has already run, will be fetched from cached results
(resulting in much improved speeds for identical patches).

> 
> > 
> > https://codereview.webrtc.org/1909223004/diff/80001/setup_links.py
> > File setup_links.py (right):
> > 
> >
https://codereview.webrtc.org/1909223004/diff/80001/setup_links.py#newcode109
> > setup_links.py:109: 'base/third_party/libevent',
> > This should work.
> 
> Looks like it! :D