webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc - Issue 1908893003: Improve the behavior when the BWE times out and when we have too little data to determine the incom…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

Issue 1908893003: Improve the behavior when the BWE times out and when we have too little data to determine the incom… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Added owners. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/base/rate_statistics_unittest.cc ('k') | webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

diff --git a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

index 5bd0627afe15485bba34cbbfae1521d3f36b1f39..8ad60aea65aff66f3a0856b94bad65ed280285e5 100644

--- a/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

+++ b/webrtc/modules/remote_bitrate_estimator/remote_bitrate_estimator_abs_send_time.cc

@@ -176,8 +176,7 @@ RemoteBitrateEstimatorAbsSendTime::ProcessClusters(int64_t now_ms) {

std::min(best_it->GetSendBitrateBps(), best_it->GetRecvBitrateBps());

// Make sure that a probe sent on a lower bitrate than our estimate can't

// reduce the estimate.

- if (IsBitrateImproving(probe_bitrate_bps) &&

- probe_bitrate_bps > static_cast<int>(incoming_bitrate_.Rate(now_ms))) {

+ if (IsBitrateImproving(probe_bitrate_bps)) {

LOG(LS_INFO) << "Probe successful, sent at "

<< best_it->GetSendBitrateBps() << " bps, received at "

<< best_it->GetRecvBitrateBps()