Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Side by Side Diff: webrtc/modules/audio_coding/neteq/expand.h

Issue 1908623002: Avoiding overflow in cross correlation in NetEq. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: turn off ubsan as it was Created 4 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved. 2 * Copyright (c) 2012 The WebRTC project authors. All Rights Reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 102 matching lines...) Expand 10 before | Expand all | Expand 10 after
113 int16_t voice_mix_factor; /* Q14 */ 113 int16_t voice_mix_factor; /* Q14 */
114 int16_t current_voice_mix_factor; /* Q14 */ 114 int16_t current_voice_mix_factor; /* Q14 */
115 AudioVector expand_vector0; 115 AudioVector expand_vector0;
116 AudioVector expand_vector1; 116 AudioVector expand_vector1;
117 bool onset; 117 bool onset;
118 int mute_slope; /* Q20 */ 118 int mute_slope; /* Q20 */
119 }; 119 };
120 120
121 // Calculate the auto-correlation of |input|, with length |input_length| 121 // Calculate the auto-correlation of |input|, with length |input_length|
122 // samples. The correlation is calculated from a downsampled version of 122 // samples. The correlation is calculated from a downsampled version of
123 // |input|, and is written to |output|. The scale factor is written to 123 // |input|, and is written to |output|.
124 // |output_scale|.
125 void Correlation(const int16_t* input, 124 void Correlation(const int16_t* input,
126 size_t input_length, 125 size_t input_length,
127 int16_t* output, 126 int16_t* output) const;
128 int* output_scale) const;
129 127
130 void UpdateLagIndex(); 128 void UpdateLagIndex();
131 129
132 BackgroundNoise* const background_noise_; 130 BackgroundNoise* const background_noise_;
133 StatisticsCalculator* const statistics_; 131 StatisticsCalculator* const statistics_;
134 const size_t overlap_length_; 132 const size_t overlap_length_;
135 size_t max_lag_; 133 size_t max_lag_;
136 size_t expand_lags_[kNumLags]; 134 size_t expand_lags_[kNumLags];
137 int lag_index_direction_; 135 int lag_index_direction_;
138 int current_lag_index_; 136 int current_lag_index_;
(...skipping 11 matching lines...) Expand all
150 virtual Expand* Create(BackgroundNoise* background_noise, 148 virtual Expand* Create(BackgroundNoise* background_noise,
151 SyncBuffer* sync_buffer, 149 SyncBuffer* sync_buffer,
152 RandomVector* random_vector, 150 RandomVector* random_vector,
153 StatisticsCalculator* statistics, 151 StatisticsCalculator* statistics,
154 int fs, 152 int fs,
155 size_t num_channels) const; 153 size_t num_channels) const;
156 }; 154 };
157 155
158 } // namespace webrtc 156 } // namespace webrtc
159 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_EXPAND_H_ 157 #endif // WEBRTC_MODULES_AUDIO_CODING_NETEQ_EXPAND_H_
OLDNEW
« no previous file with comments | « webrtc/modules/audio_coding/neteq/cross_correlation.cc ('k') | webrtc/modules/audio_coding/neteq/expand.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698