Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1411)

Issue 1907353004: Enable video processing unittest to take video clips as param. (Closed)

Created:
4 years, 8 months ago by jackychen_
Modified:
4 years, 7 months ago
Reviewers:
marpan2
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Enable video processing unittest to take video clips as param. This change enables video processing unittest (including all tests under it, e.g. denoiser test) to use a set of video clips as param, which is important if we want to do a regression test on the visual quality offline. BUG= Committed: https://crrev.com/6d94e5224a3d3b1a6d66a428dbe75af7106e8d60 Cr-Commit-Position: refs/heads/master@{#12485}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -41 lines) Patch
M webrtc/modules/video_processing/test/brightness_detection_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/modules/video_processing/test/content_metrics_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/deflickering_test.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/modules/video_processing/test/denoiser_test.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.h View 1 chunk +14 lines, -13 lines 0 comments Download
M webrtc/modules/video_processing/test/video_processing_unittest.cc View 9 chunks +23 lines, -19 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
jackychen_
4 years, 8 months ago (2016-04-22 18:28:03 UTC) #3
marpan2
lgtm
4 years, 8 months ago (2016-04-22 21:42:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907353004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907353004/1
4 years, 8 months ago (2016-04-25 06:44:55 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 07:48:05 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6d94e5224a3d3b1a6d66a428dbe75af7106e8d60 Cr-Commit-Position: refs/heads/master@{#12485}
4 years, 8 months ago (2016-04-25 07:48:16 UTC) #10
terelius
4 years, 8 months ago (2016-04-25 14:36:41 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1915973002/ by terelius@webrtc.org.

The reason for reverting is: Candidate culprit CL for breaking the gtest
initialization on DrMemory..

Powered by Google App Engine
This is Rietveld 408576698