Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Issue 1907303002: Fix test.gyp dependency. (Closed)

Created:
4 years, 8 months ago by nisse-webrtc
Modified:
4 years, 7 months ago
Reviewers:
pbos-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, the sun, pbos-webrtc, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix test.gyp dependency. BUG= Committed: https://crrev.com/037ee92455a6e7fc01efb4397a6cdcf8e49389b4 Cr-Commit-Position: refs/heads/master@{#12487}

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -2 lines) Patch
M webrtc/call/rtc_event_log_unittest.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/test/test.gyp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (8 generated)
nisse-webrtc
When working on unrelated changes, I got a presubmit error Depending on rtc_base is not ...
4 years, 8 months ago (2016-04-22 13:15:03 UTC) #2
pbos-webrtc
Fine with me, lgtm
4 years, 8 months ago (2016-04-22 15:10:09 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907303002/1
4 years, 8 months ago (2016-04-22 15:13:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-22 17:13:50 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907303002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907303002/1
4 years, 8 months ago (2016-04-25 06:50:25 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/ios_rel/builds/13131) mac_compile_dbg on tryserver.webrtc (JOB_FAILED, ...
4 years, 8 months ago (2016-04-25 06:51:19 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907303002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907303002/20001
4 years, 8 months ago (2016-04-25 07:38:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 08:39:23 UTC) #15
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 08:39:32 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/037ee92455a6e7fc01efb4397a6cdcf8e49389b4
Cr-Commit-Position: refs/heads/master@{#12487}

Powered by Google App Engine
This is Rietveld 408576698