Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 1907183002: DecoderDatabase::DecoderInfo: Remove unused member variable rtp_sample_rate_hz (Closed)

Created:
4 years, 8 months ago by kwiberg-webrtc
Modified:
4 years, 8 months ago
Reviewers:
hlundin-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc, the sun, ossu
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

DecoderDatabase::DecoderInfo: Remove unused member variable rtp_sample_rate_hz The fs_hz member variable is going away too, being replaced by a method in the AudioDecoder interface. If we ever end up needing the RTP sample rate here, a method ought to be the right solution for that too. BUG=webrtc:5801 Committed: https://crrev.com/bcc6dbb6b2276f66f323a7e97298916d799ec96d Cr-Commit-Position: refs/heads/master@{#12462}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M webrtc/modules/audio_coding/neteq/decoder_database.h View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/decoder_database.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
kwiberg-webrtc
4 years, 8 months ago (2016-04-22 02:07:03 UTC) #2
hlundin-webrtc
lgtm
4 years, 8 months ago (2016-04-22 06:49:48 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1907183002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1907183002/1
4 years, 8 months ago (2016-04-22 07:05:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 07:12:44 UTC) #6
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 07:13:00 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bcc6dbb6b2276f66f323a7e97298916d799ec96d
Cr-Commit-Position: refs/heads/master@{#12462}

Powered by Google App Engine
This is Rietveld 408576698