Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(875)

Issue 1906513002: Reland of Use initial bitrates for software VP8. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Use initial bitrates for software VP8. (patchset #1 id:1 of https://codereview.webrtc.org/1898183002/ ) Reason for revert: Chromium test updated to handle this change. Original issue's description: > Revert of Use initial bitrates for software VP8. (patchset #3 id:40001 of https://codereview.webrtc.org/1893313002/ ) > > Reason for revert: > Likely broke Chromium: > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Tester/builds/26838 > https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/builds/2224 > > Original issue's description: > > Use initial bitrates for software VP8. > > > > Makes the software encoder start at VGA as well, since ~300k isn't good > > enough to produce a good HD stream. > > > > BUG=webrtc:5678 > > R=glaznev@webrtc.org, stefan@webrtc.org > > > > Committed: https://crrev.com/e1da27e543bdb1983638118172a4efd599ca51b5 > > Cr-Commit-Position: refs/heads/master@{#12428} > > TBR=stefan@webrtc.org,glaznev@webrtc.org,pbos@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5678 > > Committed: https://crrev.com/5aa2d344d7e0b8940794d3c4422f81ac81249022 > Cr-Commit-Position: refs/heads/master@{#12430} TBR=stefan@webrtc.org,glaznev@webrtc.org,kjellander@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5678 Committed: https://crrev.com/9b2119be4743734b5b307b17e32a5a901234f283 Cr-Commit-Position: refs/heads/master@{#12447}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M webrtc/media/base/videoengine_unittest.h View 1 chunk +10 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
pbos-webrtc
Created Reland of Use initial bitrates for software VP8.
4 years, 8 months ago (2016-04-20 13:37:22 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1906513002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1906513002/1
4 years, 8 months ago (2016-04-20 13:37:31 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 13:37:40 UTC) #3
kjellander_webrtc
lgtm, but a reference to the Chromium CL would have been nice.
4 years, 8 months ago (2016-04-20 13:41:07 UTC) #4
kjellander_webrtc
On 2016/04/20 13:41:07, kjellander (webrtc) wrote: > lgtm, but a reference to the Chromium CL ...
4 years, 8 months ago (2016-04-20 13:41:46 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 13:58:06 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9b2119be4743734b5b307b17e32a5a901234f283
Cr-Commit-Position: refs/heads/master@{#12447}

Powered by Google App Engine
This is Rietveld 408576698