Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(466)

Unified Diff: webrtc/modules/video_coding/video_coding_impl.cc

Issue 1905983002: Use vcm::VideoReceiver on the receive side. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/video_coding_impl.h ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/video_coding_impl.cc
diff --git a/webrtc/modules/video_coding/video_coding_impl.cc b/webrtc/modules/video_coding/video_coding_impl.cc
index a9a4724ecffa4283b6ddd27b0b985434a644e35b..5e9b0d4230c230e821a7990d4e9983a6cdada07a 100644
--- a/webrtc/modules/video_coding/video_coding_impl.cc
+++ b/webrtc/modules/video_coding/video_coding_impl.cc
@@ -73,7 +73,6 @@ class VideoCodingModuleImpl : public VideoCodingModule {
public:
VideoCodingModuleImpl(Clock* clock,
EventFactory* event_factory,
- bool owns_event_factory,
VideoEncoderRateObserver* encoder_rate_observer,
VCMQMSettingsCallback* qm_settings_callback,
NackSender* nack_sender,
@@ -88,10 +87,9 @@ class VideoCodingModuleImpl : public VideoCodingModule {
event_factory,
pre_decode_image_callback,
nack_sender,
- keyframe_request_sender),
- own_event_factory_(owns_event_factory ? event_factory : NULL) {}
+ keyframe_request_sender) {}
- virtual ~VideoCodingModuleImpl() { own_event_factory_.reset(); }
+ virtual ~VideoCodingModuleImpl() {}
int64_t TimeUntilNextProcess() override {
int64_t sender_time = sender_.TimeUntilNextProcess();
@@ -286,7 +284,6 @@ class VideoCodingModuleImpl : public VideoCodingModule {
EncodedImageCallbackWrapper post_encode_callback_;
vcm::VideoSender sender_;
vcm::VideoReceiver receiver_;
- std::unique_ptr<EventFactory> own_event_factory_;
};
} // namespace
@@ -315,10 +312,9 @@ VideoCodingModule* VideoCodingModule::Create(
NackSender* nack_sender,
KeyFrameRequestSender* keyframe_request_sender,
EncodedImageCallback* pre_decode_image_callback) {
- return new VideoCodingModuleImpl(clock, new EventFactoryImpl, true,
- encoder_rate_observer, qm_settings_callback,
- nack_sender, keyframe_request_sender,
- pre_decode_image_callback);
+ return new VideoCodingModuleImpl(
+ clock, nullptr, encoder_rate_observer, qm_settings_callback, nack_sender,
+ keyframe_request_sender, pre_decode_image_callback);
}
// Create method for current interface, will be removed when the
@@ -338,9 +334,9 @@ VideoCodingModule* VideoCodingModule::Create(
KeyFrameRequestSender* keyframe_request_sender) {
assert(clock);
assert(event_factory);
- return new VideoCodingModuleImpl(clock, event_factory, false, nullptr,
- nullptr, nack_sender,
- keyframe_request_sender, nullptr);
+ return new VideoCodingModuleImpl(clock, event_factory, nullptr, nullptr,
+ nack_sender, keyframe_request_sender,
+ nullptr);
}
} // namespace webrtc
« no previous file with comments | « webrtc/modules/video_coding/video_coding_impl.h ('k') | webrtc/video/video_receive_stream.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698