Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1319)

Issue 1905583002: Reland of Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. (patchset #1 id:1 of https://codereview.webrtc.org/1903193002/ ) Reason for revert: A fix is being prepared downstream so this can now go in. Original issue's description: > Revert of Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. (patchset #5 id:80001 of https://codereview.webrtc.org/1897233002/ ) > > Reason for revert: > API changes broke downstream. > > Original issue's description: > > Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. > > EncodedImageCallback is used by all encoder implementations and seems to be what we should try to use in the transport. > > EncodedImageCallback can of course be cleaned up in the future. > > > > This moves creation of RTPVideoHeader from the GenericEncoder to the PayLoadRouter. > > > > BUG=webrtc::5687 > > > > Committed: https://crrev.com/f5d55aaecdc39e9cc66eb6e87614f04afe28f6eb > > Cr-Commit-Position: refs/heads/master@{#12436} > > TBR=stefan@webrtc.org,pbos@webrtc.org,perkj@webrtc.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=webrtc:5687 > > Committed: https://crrev.com/a261e6136655af33f283eda8e60a6dd93dd746a4 > Cr-Commit-Position: refs/heads/master@{#12441} TBR=stefan@webrtc.org,pbos@webrtc.org,perkj@webrtc.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=webrtc:5687 Committed: https://crrev.com/02b3d275a0465c93dd19fb30bd3ea051de5d9256 Cr-Commit-Position: refs/heads/master@{#12442}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+351 lines, -351 lines) Patch
M webrtc/modules/video_coding/codec_database.cc View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.h View 2 chunks +0 lines, -2 lines 0 comments Download
M webrtc/modules/video_coding/generic_encoder.cc View 3 chunks +2 lines, -84 lines 0 comments Download
M webrtc/modules/video_coding/include/video_coding_defines.h View 1 chunk +3 lines, -5 lines 0 comments Download
M webrtc/modules/video_coding/utility/ivf_file_writer.h View 1 chunk +3 lines, -3 lines 0 comments Download
M webrtc/modules/video_coding/utility/ivf_file_writer.cc View 3 chunks +6 lines, -7 lines 0 comments Download
M webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/video_sender_unittest.cc View 8 chunks +23 lines, -26 lines 0 comments Download
M webrtc/video/encoder_state_feedback_unittest.cc View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/video/payload_router.h View 4 chunks +10 lines, -12 lines 0 comments Download
M webrtc/video/payload_router.cc View 2 chunks +97 lines, -21 lines 0 comments Download
M webrtc/video/payload_router_unittest.cc View 7 chunks +85 lines, -67 lines 0 comments Download
M webrtc/video/send_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/send_statistics_proxy.cc View 3 chunks +18 lines, -9 lines 0 comments Download
M webrtc/video/send_statistics_proxy_unittest.cc View 7 chunks +38 lines, -38 lines 0 comments Download
M webrtc/video/video_receive_stream.cc View 1 chunk +2 lines, -17 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/video/vie_encoder.h View 6 chunks +10 lines, -9 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 8 chunks +30 lines, -26 lines 0 comments Download
M webrtc/video_encoder.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
kjellander_webrtc
Created Reland of Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead.
4 years, 8 months ago (2016-04-20 12:05:39 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1905583002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1905583002/1
4 years, 8 months ago (2016-04-20 12:05:46 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 12:05:58 UTC) #4
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 12:26:24 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/02b3d275a0465c93dd19fb30bd3ea051de5d9256
Cr-Commit-Position: refs/heads/master@{#12442}

Powered by Google App Engine
This is Rietveld 408576698