Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 1905573002: Fix missing-break-fallthrough warning. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman, philipel
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fix missing-break-fallthrough warning. Adds a break; after RTC_NOTREACHED(). Also removes default case to catch if any other codec type is added. BUG= R=stefan@webrtc.org Committed: https://crrev.com/2ddf09397fa8b3864eec135b1c56cb3530dd3765 Cr-Commit-Position: refs/heads/master@{#12443}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -13 lines) Patch
M webrtc/modules/video_coding/packet_buffer.cc View 1 chunk +10 lines, -13 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
stefan-webrtc
+philipel who wrote this code.
4 years, 8 months ago (2016-04-20 12:05:06 UTC) #2
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-20 12:05:28 UTC) #3
pbos-webrtc
Committed patchset #1 (id:1) manually as 2ddf09397fa8b3864eec135b1c56cb3530dd3765 (presubmit successful).
4 years, 8 months ago (2016-04-20 12:06:59 UTC) #5
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 12:26:26 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2ddf09397fa8b3864eec135b1c56cb3530dd3765
Cr-Commit-Position: refs/heads/master@{#12443}

Powered by Google App Engine
This is Rietveld 408576698