Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(445)

Issue 1904983002: Use vcm::VideoSender in ViEEncoder. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
perkj_webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use vcm::VideoSender in ViEEncoder. ViEEncoder doesn't need a full VideoCodingModule since it only uses the sender side either way. BUG=webrtc:3608, webrtc:5687 R=perkj@webrtc.org Committed: https://crrev.com/cd5c25cb801fa0a1a2f1c7e453354ccb0e65beff Cr-Commit-Position: refs/heads/master@{#12456}

Patch Set 1 #

Patch Set 2 : remove more dead code #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -109 lines) Patch
M tools/valgrind-webrtc/drmemory/suppressions.txt View 1 chunk +0 lines, -41 lines 0 comments Download
M tools/valgrind-webrtc/memcheck/suppressions.txt View 1 chunk +0 lines, -17 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/video_send_stream.h View 2 chunks +5 lines, -1 line 0 comments Download
M webrtc/video/video_send_stream.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M webrtc/video/vie_encoder.h View 4 chunks +4 lines, -5 lines 0 comments Download
M webrtc/video/vie_encoder.cc View 1 10 chunks +20 lines, -39 lines 0 comments Download

Messages

Total messages: 13 (6 generated)
pbos-webrtc
PTAL
4 years, 8 months ago (2016-04-21 13:50:01 UTC) #1
pbos-webrtc
remove more dead code
4 years, 8 months ago (2016-04-21 13:51:37 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904983002/20001
4 years, 8 months ago (2016-04-21 14:02:46 UTC) #4
perkj_webrtc
lgtm
4 years, 8 months ago (2016-04-21 14:07:27 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904983002/20001
4 years, 8 months ago (2016-04-21 14:07:40 UTC) #9
pbos-webrtc
Committed patchset #2 (id:20001) manually as cd5c25cb801fa0a1a2f1c7e453354ccb0e65beff (presubmit successful).
4 years, 8 months ago (2016-04-21 14:48:27 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-21 15:02:22 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cd5c25cb801fa0a1a2f1c7e453354ccb0e65beff
Cr-Commit-Position: refs/heads/master@{#12456}

Powered by Google App Engine
This is Rietveld 408576698