Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 1904343002: Create new webrtc/sdk subdirectory. (Closed)

Created:
4 years, 8 months ago by tkchin_webrtc
Modified:
4 years, 7 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Create new webrtc/sdk subdirectory. This will be the staging around for languages other than C++. Right now only ObjC is planned in the near future. BUG= Committed: https://crrev.com/1d4a4b971093a4291069153f5fce9ae3dfb2480e Cr-Commit-Position: refs/heads/master@{#12496}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-1 lines, --1 lines) Patch
A + webrtc/sdk/OWNERS View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
tkchin_webrtc
Teasing apart https://codereview.webrtc.org/1903663002/ Can one of you approve the creation of this new base directory ...
4 years, 8 months ago (2016-04-21 23:25:24 UTC) #3
tommi
lgtm
4 years, 8 months ago (2016-04-22 19:25:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904343002/1
4 years, 8 months ago (2016-04-22 19:34:01 UTC) #6
mflodman
lgtm
4 years, 8 months ago (2016-04-25 04:20:29 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1904343002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1904343002/1
4 years, 8 months ago (2016-04-25 22:46:42 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-25 23:45:26 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 23:45:35 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1d4a4b971093a4291069153f5fce9ae3dfb2480e
Cr-Commit-Position: refs/heads/master@{#12496}

Powered by Google App Engine
This is Rietveld 408576698