Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 1903553005: Remove root dir from protoc.gypi include paths. (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
Reviewers:
phoglund
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove root dir from protoc.gypi include paths. This include directory doesn't seem to be needed and is causing problems in some downstream projects. NOTRY=True Committed: https://crrev.com/40bebd3c11fbb2a30e80b922c39b9170975959b1 Cr-Commit-Position: refs/heads/master@{#12445}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -2 lines) Patch
M webrtc/build/protoc.gypi View 2 chunks +5 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
kjellander_webrtc
4 years, 8 months ago (2016-04-20 12:12:03 UTC) #2
phoglund
lgtm
4 years, 8 months ago (2016-04-20 13:00:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903553005/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903553005/1
4 years, 8 months ago (2016-04-20 13:16:25 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-20 13:22:23 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 13:27:24 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/40bebd3c11fbb2a30e80b922c39b9170975959b1
Cr-Commit-Position: refs/heads/master@{#12445}

Powered by Google App Engine
This is Rietveld 408576698