Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 1903553003: Remove the rtc_relative_path GYP variable and similar defines (Closed)

Created:
4 years, 8 months ago by kjellander_webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, qiang.lu, niklas.enbom, yujie_mao (webrtc), peah-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Remove the rtc_relative_path GYP variable and similar defines The defines that can be used to alter the include paths for Expat, SRTP and gtest are no longer needed in WebRTC or Chromium. Let's remove them to simplify the GYP a little. Removed defines: EXPAT_RELATIVE_PATH GTEST_RELATIVE_PATH SRTP_RELATIVE_PATH They're all set in the Chromium build so this shouldn't affect Chromium: https://code.google.com/p/chromium/codesearch#chromium/src/third_party/libjingle/libjingle.gyp BUG=webrtc:4256 NOTRY=True NOPRESUBMIT=True Committed: https://crrev.com/e19cf59eb6ee44fd4d7e7fbcfdd1a6ea75063605 Cr-Commit-Position: refs/heads/master@{#12467}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -54 lines) Patch
M webrtc/base/base_tests.gyp View 1 chunk +0 lines, -8 lines 0 comments Download
M webrtc/base/gunit.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/base/gunit_prod.h View 1 chunk +1 line, -4 lines 0 comments Download
M webrtc/build/common.gypi View 2 chunks +0 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmllite/xmlbuilder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmllite/xmlparser.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/libjingle/xmpp/xmppstanzaparser.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/pc/externalhmac.h View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/pc/externalhmac.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/pc/pc.gyp View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/pc/srtpfilter.cc View 1 chunk +0 lines, -5 lines 0 comments Download
M webrtc/pc/srtpfilter_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M webrtc/webrtc_tests.gypi View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 20 (10 generated)
kjellander_webrtc
A small cleanup step towards removing talk/.
4 years, 8 months ago (2016-04-19 21:29:07 UTC) #3
kjellander_webrtc
+perkj to offload pthatcher.
4 years, 8 months ago (2016-04-21 12:35:51 UTC) #5
perkj_webrtc
lgtm
4 years, 8 months ago (2016-04-22 09:57:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903553003/1
4 years, 8 months ago (2016-04-22 11:20:28 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/5002)
4 years, 8 months ago (2016-04-22 11:24:59 UTC) #11
kjellander_webrtc
On 2016/04/22 11:24:59, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 8 months ago (2016-04-22 11:41:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903553003/1
4 years, 8 months ago (2016-04-22 11:41:45 UTC) #15
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 11:41:55 UTC) #17
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/e19cf59eb6ee44fd4d7e7fbcfdd1a6ea75063605 Cr-Commit-Position: refs/heads/master@{#12467}
4 years, 8 months ago (2016-04-22 11:42:03 UTC) #19
kjellander_webrtc
4 years, 8 months ago (2016-04-22 11:57:34 UTC) #20
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.webrtc.org/1913043003/ by kjellander@webrtc.org.

The reason for reverting is: Breaks downstream for SRTP include paths. Will
rework this and reland without that one..

Powered by Google App Engine
This is Rietveld 408576698