Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Unified Diff: webrtc/modules/video_coding/packet_buffer.h

Issue 1903523003: Convert Vp9 Rtp headers to frame references. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Feedback fixes. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/packet_buffer.h
diff --git a/webrtc/modules/video_coding/packet_buffer.h b/webrtc/modules/video_coding/packet_buffer.h
index caa81f6b99e99f8400298dbc70558676ddcb2606..bf8af153eb5adde0c23c0dbd667ff17ab40d9946 100644
--- a/webrtc/modules/video_coding/packet_buffer.h
+++ b/webrtc/modules/video_coding/packet_buffer.h
@@ -12,6 +12,7 @@
#define WEBRTC_MODULES_VIDEO_CODING_PACKET_BUFFER_H_
#include <array>
+#include <utility>
#include <vector>
#include <map>
#include <set>
@@ -20,6 +21,7 @@
#include "webrtc/base/criticalsection.h"
#include "webrtc/base/scoped_ptr.h"
#include "webrtc/base/thread_annotations.h"
+#include "webrtc/modules/include/module_common_types.h"
#include "webrtc/modules/video_coding/packet.h"
#include "webrtc/modules/video_coding/sequence_number_util.h"
@@ -48,10 +50,11 @@ class PacketBuffer {
private:
static const uint16_t kPicIdLength = 1 << 7;
- static const uint8_t kMaxTemporalLayer = 5;
+ static const uint8_t kMaxTemporalLayers = 5;
static const int kMaxStashedFrames = 10;
static const int kMaxLayerInfo = 10;
static const int kMaxNotYetReceivedFrames = 20;
+ static const int kMaxGofSaved = 15;
friend RtpFrameObject;
// Since we want the packet buffer to be as packet type agnostic
@@ -115,10 +118,38 @@ class PacketBuffer {
void CompletedFrameVp8(std::unique_ptr<RtpFrameObject> frame)
EXCLUSIVE_LOCKS_REQUIRED(crit_);
+ // Find references for Vp9 frames
+ void ManageFrameVp9(std::unique_ptr<RtpFrameObject> frame)
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
+
+ // Unwrap the picture id and the frame references and then call the
+ // |frame_callback| callback with the completed frame.
+ void CompletedFrameVp9(std::unique_ptr<RtpFrameObject> frame)
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
+
+ // Check if we are missing a frame necessary to determine the references
+ // for this frame.
+ bool MissingRequiredFrameVp9(uint16_t picture_id, const GofInfoVP9& gof)
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
+
+ // Updates which frames that have been received. If there is a gap,
+ // missing frames will be added to |missing_frames_for_layer_| or
+ // if this is an already missing frame then it will be removed.
+ void FrameReceivedVp9(uint16_t picture_id, const GofInfoVP9& gof)
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
+
+ // Check if there is a frame with the up-switch flag set in the interval
+ // (|pid_ref|, |picture_id|) with temporal layer smaller than |temporal_idx|.
+ bool UpSwitchInIntervalVp9(uint16_t picture_id,
+ uint8_t temporal_idx,
+ uint16_t pid_ref)
+ EXCLUSIVE_LOCKS_REQUIRED(crit_);
+
// All picture ids are unwrapped to 16 bits.
uint16_t UnwrapPictureId(uint16_t picture_id)
EXCLUSIVE_LOCKS_REQUIRED(crit_);
+
rtc::CriticalSection crit_;
// Buffer size_ and max_size_ must always be a power of two.
@@ -160,7 +191,7 @@ class PacketBuffer {
// Frames earlier than the last received frame that have not yet been
// fully received.
- std::set<uint8_t, DescendingSeqNumComp<uint8_t, kPicIdLength>>
+ std::set<uint16_t, DescendingSeqNumComp<uint16_t, kPicIdLength>>
not_yet_received_frames_ GUARDED_BY(crit_);
// Frames that have been fully received but didn't have all the information
@@ -170,8 +201,30 @@ class PacketBuffer {
// Holds the information about the last completed frame for a given temporal
// layer given a Tl0 picture index.
std::map<uint8_t,
- std::array<int16_t, kMaxTemporalLayer>,
+ std::array<int16_t, kMaxTemporalLayers>,
DescendingSeqNumComp<uint8_t>> layer_info_ GUARDED_BY(crit_);
+
+ // Where the current scalability structure is in the
+ // |scalability_structures_| array.
+ uint8_t current_ss_idx_;
+
+ // Holds received scalability structures.
+ std::array<GofInfoVP9, kMaxGofSaved>
+ scalability_structures_ GUARDED_BY(crit_);
+
+ // Holds the picture id and the Gof information for a given TL0 picture index.
+ std::map<uint8_t,
+ std::pair<uint16_t, GofInfoVP9*>,
+ DescendingSeqNumComp<uint8_t>> gof_info_ GUARDED_BY(crit_);
+
+ // Keep track of which picture id and which temporal layer that had the
+ // up switch flag set.
+ std::map<uint16_t, uint8_t> up_switch_ GUARDED_BY(crit_);
+
+ // For every temporal layer, keep a set of which frames that are missing.
+ std::array<
+ std::set<uint16_t, DescendingSeqNumComp<uint16_t, kPicIdLength>>,
+ kMaxTemporalLayers> missing_frames_for_layer_ GUARDED_BY(crit_);
};
} // namespace video_coding

Powered by Google App Engine
This is Rietveld 408576698