Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Issue 1903153005: Add a TickTimer object to NetEqImpl (Closed)

Created:
4 years, 8 months ago by hlundin-webrtc
Modified:
4 years, 7 months ago
Reviewers:
tlegrand-webrtc
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@neteq-tick-timer
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add a TickTimer object to NetEqImpl The TickTimer is incremented on each call to GetAudioInternal(). Other than that, the new object is not used yet. Also adding a unit test in NetEqImplTest to verify that the tick timer is incremented in the call to NetEq::GetAudio. BUG=webrtc:5608 Committed: https://crrev.com/ed4972116c36ac1df3b0e0701f0fb9834a9e563c Cr-Commit-Position: refs/heads/master@{#12493}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M webrtc/modules/audio_coding/neteq/neteq.cc View 3 chunks +7 lines, -13 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.h View 3 chunks +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl.cc View 4 chunks +5 lines, -1 line 0 comments Download
M webrtc/modules/audio_coding/neteq/neteq_impl_unittest.cc View 4 chunks +18 lines, -13 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 12 (5 generated)
hlundin-webrtc
Tina, Please, review this CL. Thanks!
4 years, 8 months ago (2016-04-21 08:26:51 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903153005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903153005/20001
4 years, 8 months ago (2016-04-24 20:06:37 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 8 months ago (2016-04-24 21:09:30 UTC) #6
tlegrand-webrtc
lgtm
4 years, 8 months ago (2016-04-25 12:33:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1903153005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1903153005/20001
4 years, 8 months ago (2016-04-25 17:09:42 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-25 17:11:42 UTC) #10
commit-bot: I haz the power
4 years, 8 months ago (2016-04-25 17:11:49 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/ed4972116c36ac1df3b0e0701f0fb9834a9e563c
Cr-Commit-Position: refs/heads/master@{#12493}

Powered by Google App Engine
This is Rietveld 408576698