Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(412)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1902543002: Move frame_callback.h to common_video/include. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, interface-changes_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, qiang.lu, niklas.enbom, peah-webrtc, pbos-webrtc, perkj_webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Move frame_callback.h to common_video/include. BUG=webrtc:4243 R=kjellander@webrtc.org, tommi@webrtc.org Committed: https://crrev.com/a96b60b3a6e1bafa7cbf63f5cb325ded83880137 Cr-Commit-Position: refs/heads/master@{#12419}

Patch Set 1 #

Total comments: 2

Patch Set 2 : sort vie_encoder.cc headers #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -72 lines) Patch
M webrtc/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M webrtc/DEPS View 2 chunks +2 lines, -1 line 0 comments Download
M webrtc/common_video/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/common_video/common_video.gyp View 1 chunk +1 line, -0 lines 0 comments Download
A + webrtc/common_video/include/frame_callback.h View 2 chunks +3 lines, -3 lines 0 comments Download
D webrtc/frame_callback.h View 1 chunk +0 lines, -55 lines 0 comments Download
M webrtc/modules/video_coding/video_coding_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/encoded_frame_callback_adapter.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/end_to_end_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/overuse_frame_detector.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/receive_statistics_proxy.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_channel.cc View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video/vie_encoder.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M webrtc/video_receive_stream.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/video_send_stream.h View 1 chunk +1 line, -1 line 0 comments Download
M webrtc/webrtc.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 23 (10 generated)
pbos-webrtc
PTAL, this should've been a fairly easy one, and it looks unused elsewhere.
4 years, 8 months ago (2016-04-18 20:13:11 UTC) #1
kjellander_webrtc
lgtm with nit https://codereview.webrtc.org/1902543002/diff/1/webrtc/video/vie_encoder.cc File webrtc/video/vie_encoder.cc (right): https://codereview.webrtc.org/1902543002/diff/1/webrtc/video/vie_encoder.cc#newcode22 webrtc/video/vie_encoder.cc:22: #include "webrtc/common_video/include/frame_callback.h" sort alphabetically.
4 years, 8 months ago (2016-04-18 20:33:08 UTC) #2
pbos-webrtc
sort vie_encoder.cc headers
4 years, 8 months ago (2016-04-18 20:36:25 UTC) #3
pbos-webrtc
https://codereview.webrtc.org/1902543002/diff/1/webrtc/video/vie_encoder.cc File webrtc/video/vie_encoder.cc (right): https://codereview.webrtc.org/1902543002/diff/1/webrtc/video/vie_encoder.cc#newcode22 webrtc/video/vie_encoder.cc:22: #include "webrtc/common_video/include/frame_callback.h" On 2016/04/18 20:33:08, kjellander (webrtc) wrote: > ...
4 years, 8 months ago (2016-04-18 20:36:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902543002/20001
4 years, 8 months ago (2016-04-18 20:36:51 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4906)
4 years, 8 months ago (2016-04-18 20:42:42 UTC) #9
pbos-webrtc
+tommi@, can you stamp as root owner?
4 years, 8 months ago (2016-04-18 20:46:54 UTC) #12
tommi
lgtm
4 years, 8 months ago (2016-04-18 20:58:48 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902543002/20001
4 years, 8 months ago (2016-04-18 21:14:05 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-18 22:37:30 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1902543002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1902543002/20001
4 years, 8 months ago (2016-04-19 04:11:12 UTC) #19
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-19 04:12:53 UTC) #21
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 04:13:03 UTC) #23
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/a96b60b3a6e1bafa7cbf63f5cb325ded83880137
Cr-Commit-Position: refs/heads/master@{#12419}

Powered by Google App Engine
This is Rietveld 408576698