Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(941)

Unified Diff: webrtc/media/engine/webrtcvideoengine2_unittest.cc

Issue 1902413002: Fix flake in TwoStreamsSendAndReceive. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/media/base/videoengine_unittest.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/media/engine/webrtcvideoengine2_unittest.cc
diff --git a/webrtc/media/engine/webrtcvideoengine2_unittest.cc b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
index 95d418e7983b90dc471c394bbfb00b9488798eee..5f99f9ef89f0556e9a1e279a5703ee049c03970b 100644
--- a/webrtc/media/engine/webrtcvideoengine2_unittest.cc
+++ b/webrtc/media/engine/webrtcvideoengine2_unittest.cc
@@ -871,7 +871,14 @@ TEST_F(WebRtcVideoChannel2BaseTest, SendAndReceiveVp8SvcQqvga) {
}
TEST_F(WebRtcVideoChannel2BaseTest, TwoStreamsSendAndReceive) {
- Base::TwoStreamsSendAndReceive(kVp8Codec);
+ // Set a high bitrate to not be downscaled by VP8 due to low initial start
+ // bitrates. This currently happens at <250k, and two streams sharing 300k
+ // initially will use QVGA instead of VGA initially.
stefan-webrtc 2016/04/20 14:26:59 Remove one "initially"
+ // TODO(pbos): Set up the quality scaler so that both senders reliably start
+ // at QVGA, then verify that instead.
+ cricket::VideoCodec codec = kVp8Codec;
+ codec.params[kCodecParamStartBitrate] = "1000000";
+ Base::TwoStreamsSendAndReceive(codec);
}
class WebRtcVideoChannel2Test : public WebRtcVideoEngine2Test {
« no previous file with comments | « webrtc/media/base/videoengine_unittest.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698