Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: webrtc/modules/video_processing/video_processing_impl.h

Issue 1901393003: Delete unused methods of the VideoProcessing class. And fix a typo. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_processing/video_processing_impl.h
diff --git a/webrtc/modules/video_processing/video_processing_impl.h b/webrtc/modules/video_processing/video_processing_impl.h
index 1d9a3775cf1d6682366fdb989b951ef23d955cfa..c750f888a8b28dc16f59b3ef81302ff9238b05fa 100644
--- a/webrtc/modules/video_processing/video_processing_impl.h
+++ b/webrtc/modules/video_processing/video_processing_impl.h
@@ -13,8 +13,6 @@
#include "webrtc/base/criticalsection.h"
#include "webrtc/modules/video_processing/include/video_processing.h"
-#include "webrtc/modules/video_processing/brightness_detection.h"
-#include "webrtc/modules/video_processing/deflickering.h"
#include "webrtc/modules/video_processing/frame_preprocessor.h"
namespace webrtc {
@@ -26,9 +24,6 @@ class VideoProcessingImpl : public VideoProcessing {
~VideoProcessingImpl() override;
// Implements VideoProcessing.
- int32_t Deflickering(VideoFrame* frame, FrameStats* stats) override;
- int32_t BrightnessDetection(const VideoFrame& frame,
- const FrameStats& stats) override;
void EnableTemporalDecimation(bool enable) override;
void SetInputFrameResampleMode(VideoFrameResampling resampling_mode) override;
void EnableContentAnalysis(bool enable) override;
@@ -39,14 +34,12 @@ class VideoProcessingImpl : public VideoProcessing {
uint32_t GetDecimatedFrameRate() override;
uint32_t GetDecimatedWidth() const override;
uint32_t GetDecimatedHeight() const override;
- void EnableDenosing(bool enable) override;
+ void EnableDenoising(bool enable) override;
const VideoFrame* PreprocessFrame(const VideoFrame& frame) override;
VideoContentMetrics* GetContentMetrics() const override;
private:
rtc::CriticalSection mutex_;
pbos-webrtc 2016/04/24 18:19:42 Does this guard anything anymore? If so annotate i
nisse-webrtc 2016/04/25 06:42:34 It protects the frame_pre_processor_. In fact, wha
- VPMDeflickering deflickering_ GUARDED_BY(mutex_);
- VPMBrightnessDetection brightness_detection_;
VPMFramePreprocessor frame_pre_processor_;
};
« no previous file with comments | « webrtc/modules/video_processing/video_processing.gypi ('k') | webrtc/modules/video_processing/video_processing_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698