Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Unified Diff: webrtc/video_frame.h

Issue 1900673002: Delete webrtc::VideoFrame methods buffer and stride. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Update H.264 video_toolbox encoder. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/video_frame.h
diff --git a/webrtc/video_frame.h b/webrtc/video_frame.h
index b5e13f039b0cd6c7f7f2920cab126124c39039a9..a04c580458dba508267c070eba663aca0a578b64 100644
--- a/webrtc/video_frame.h
+++ b/webrtc/video_frame.h
@@ -68,17 +68,9 @@ class VideoFrame {
// Release frame buffer and reset time stamps.
void Reset();
- // Get pointer to buffer per plane.
- uint8_t* buffer(PlaneType type);
- // Overloading with const.
- const uint8_t* buffer(PlaneType type) const;
-
// Get allocated size per plane.
int allocated_size(PlaneType type) const;
- // Get allocated stride per plane.
- int stride(PlaneType type) const;
-
// Get frame width.
int width() const;
@@ -127,7 +119,11 @@ class VideoFrame {
// Return the underlying buffer. Never nullptr for a properly
// initialized VideoFrame.
- rtc::scoped_refptr<webrtc::VideoFrameBuffer> video_frame_buffer() const;
+ // Creating a new reference breaks the (admittedly brittle)
pbos-webrtc 2016/04/19 11:28:47 Don't think the "admittedly brittle" part is neces
nisse-webrtc 2016/04/19 13:55:39 Ok, dropped it.
+ // HasOneRef and IsMutable logic. So return a const ref to our
+ // reference.
+ const rtc::scoped_refptr<webrtc::VideoFrameBuffer>& video_frame_buffer()
+ const;
// Set the underlying buffer.
void set_video_frame_buffer(
« webrtc/common_video/video_frame.cc ('K') | « webrtc/video/video_encoder_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698