webrtc/modules/video_processing/test/brightness_detection_test.cc - Issue 1900673002: Delete webrtc::VideoFrame methods buffer and stride.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_processing/test/brightness_detection_test.cc

Issue 1900673002: Delete webrtc::VideoFrame methods buffer and stride. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Update H.264 video_toolbox encoder. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_video/video_frame.cc ('K') | « webrtc/modules/video_processing/deflickering.cc ('k') | webrtc/modules/video_processing/test/video_processing_unittest.cc » ('j') | webrtc/video_frame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_processing/test/brightness_detection_test.cc

diff --git a/webrtc/modules/video_processing/test/brightness_detection_test.cc b/webrtc/modules/video_processing/test/brightness_detection_test.cc

index abce518e5841f7faffc77692dec3183fb2ca0b46..f34bc573ad5ca7888bc71d16f1e02e44f7faa5f2 100644

--- a/webrtc/modules/video_processing/test/brightness_detection_test.cc

+++ b/webrtc/modules/video_processing/test/brightness_detection_test.cc

@@ -58,7 +58,7 @@ TEST_F(VideoProcessingTest, MAYBE_BrightnessDetection) {

0, kVideoRotation_0, &video_frame_));

frameNum++;

- uint8_t* frame = video_frame_.buffer(kYPlane);

+ uint8_t* frame = video_frame_.video_frame_buffer()->MutableDataY();

uint32_t yTmp = 0;

for (int yIdx = 0; yIdx < width_ * height_; yIdx++) {

yTmp = frame[yIdx] << 1;

@@ -95,7 +95,7 @@ TEST_F(VideoProcessingTest, MAYBE_BrightnessDetection) {

0, kVideoRotation_0, &video_frame_));

frameNum++;

- uint8_t* y_plane = video_frame_.buffer(kYPlane);

+ uint8_t* y_plane = video_frame_.video_frame_buffer()->MutableDataY();

int32_t yTmp = 0;

for (int yIdx = 0; yIdx < width_ * height_; yIdx++) {

yTmp = y_plane[yIdx] >> 1;