webrtc/modules/video_processing/brightness_detection.cc - Issue 1900673002: Delete webrtc::VideoFrame methods buffer and stride.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_processing/brightness_detection.cc

Issue 1900673002: Delete webrtc::VideoFrame methods buffer and stride. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Update H.264 video_toolbox encoder. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/common_video/video_frame.cc ('K') | « webrtc/modules/video_coding/codecs/vp9/vp9_impl.cc ('k') | webrtc/modules/video_processing/content_analysis.cc » ('j') | webrtc/video_frame.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_processing/brightness_detection.cc

diff --git a/webrtc/modules/video_processing/brightness_detection.cc b/webrtc/modules/video_processing/brightness_detection.cc

index 7455cf975917c08c629e4e63d3fd9c083d11e1ee..1008c259ed654848cc93d221cef8eed52a08b969 100644

--- a/webrtc/modules/video_processing/brightness_detection.cc

+++ b/webrtc/modules/video_processing/brightness_detection.cc

@@ -61,7 +61,7 @@ int32_t VPMBrightnessDetection::ProcessFrame(

if (prop_high < 0.4) {

if (stats.mean < 90 || stats.mean > 170) {

// Standard deviation of Y

- const uint8_t* buffer = frame.buffer(kYPlane);

+ const uint8_t* buffer = frame.video_frame_buffer()->DataY();

float std_y = 0;

for (int h = 0; h < height; h += (1 << stats.sub_sampling_factor)) {

int row = h * width;