Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Unified Diff: webrtc/modules/video_coding/utility/quality_scaler_unittest.cc

Issue 1900483004: Add QVGA to thresholds for initial quality. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: move constants Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/modules/video_coding/utility/quality_scaler.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
diff --git a/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc b/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
index 0f761c7d1768cfaa67aa98885f3cbcbfb1f08388..58c41ad315a2659280b9af84e9210bc3e2278fb8 100644
--- a/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
+++ b/webrtc/modules/video_coding/utility/quality_scaler_unittest.cc
@@ -16,10 +16,8 @@ namespace webrtc {
namespace {
static const int kNumSeconds = 10;
static const int kWidth = 1920;
-static const int kWidthVga = 640;
static const int kHalfWidth = kWidth / 2;
static const int kHeight = 1080;
-static const int kHeightVga = 480;
static const int kFramerate = 30;
static const int kLowQp = 15;
static const int kNormalQp = 30;
@@ -380,13 +378,33 @@ TEST_F(QualityScalerTest, DoesNotDownscaleBelow2xDefaultMinDimensionsHeight) {
}
TEST_F(QualityScalerTest, DownscaleToVgaOnLowInitialBitrate) {
- qs_.Init(kLowQpThreshold, kDisabledBadQpThreshold, true,
- kLowInitialBitrateKbps, kWidth, kHeight, kFramerate);
+ static const int kWidth720p = 1280;
+ static const int kHeight720p = 720;
+ static const int kInitialBitrateKbps = 300;
+ input_frame_.CreateEmptyFrame(kWidth720p, kHeight720p, kWidth720p,
+ kWidth720p / 2, kWidth720p / 2);
+ qs_.Init(kLowQpThreshold, kDisabledBadQpThreshold, true, kInitialBitrateKbps,
+ kWidth720p, kHeight720p, kFramerate);
qs_.OnEncodeFrame(input_frame_);
int init_width = qs_.GetScaledResolution().width;
int init_height = qs_.GetScaledResolution().height;
- EXPECT_LE(init_width, kWidthVga);
- EXPECT_LE(init_height, kHeightVga);
+ EXPECT_EQ(640, init_width);
+ EXPECT_EQ(360, init_height);
+}
+
+TEST_F(QualityScalerTest, DownscaleToQvgaOnLowerInitialBitrate) {
+ static const int kWidth720p = 1280;
+ static const int kHeight720p = 720;
+ static const int kInitialBitrateKbps = 200;
+ input_frame_.CreateEmptyFrame(kWidth720p, kHeight720p, kWidth720p,
+ kWidth720p / 2, kWidth720p / 2);
+ qs_.Init(kLowQpThreshold, kDisabledBadQpThreshold, true, kInitialBitrateKbps,
+ kWidth720p, kHeight720p, kFramerate);
+ qs_.OnEncodeFrame(input_frame_);
+ int init_width = qs_.GetScaledResolution().width;
+ int init_height = qs_.GetScaledResolution().height;
+ EXPECT_EQ(320, init_width);
+ EXPECT_EQ(180, init_height);
}
TEST_F(QualityScalerTest, DownscaleAfterMeasuredSecondsThenSlowerBackUp) {
« no previous file with comments | « webrtc/modules/video_coding/utility/quality_scaler.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698