Add QVGA to thresholds for initial quality.

Add QVGA to thresholds for initial quality.

Makes QualityScaler start at QVGA for <250k initial bitrates. Useful in
combination with overriding max bitrates to a max lower than that for
connections where we know that the max bitrate is capped below where VGA
is useful.

BUG=webrtc:5678
R=glaznev@webrtc.org

Committed: https://chromium.googlesource.com/external/webrtc/+/b9e77097ed200ce671ce4c10bf624211db6b5665

[pbos-webrtc, 2016-04-18 14:15:02]

Description was changed from

==========
Add QVGA to thresholds for initial quality.

Makes QualityScaler start at QVGA for <250k initial bitrates. Useful in
combination with overriding max bitrates to a max lower than that for
connections where we know that the max bitrate is capped below where VGA
is useful.

BUG=webrtc:5678
R=stefan@webrtc.org
==========

to

==========
Add QVGA to thresholds for initial quality.

Makes QualityScaler start at QVGA for <250k initial bitrates. Useful in
combination with overriding max bitrates to a max lower than that for
connections where we know that the max bitrate is capped below where VGA
is useful.

BUG=webrtc:5678
R=glaznev@webrtc.org
==========

[pbos-webrtc, 2016-04-18 14:15:02]

pbos@webrtc.org changed reviewers:
+ glaznev@webrtc.org
- stefan@webrtc.org

[pbos-webrtc, 2016-04-18 14:16:36]

PTAL, this doesn't trigger anywhere currently, but gets enabled if we override
max/start bitrates, which I think makes sense for lower-end 3G connections (that
are spec:ed to 200k).

[pbos-webrtc, 2016-04-18 14:38:30]

The CQ bit was checked by pbos@webrtc.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-18 14:38:33]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1900483004/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1900483004/1

[commit-bot: I haz the power, 2016-04-18 16:39:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-18 16:39:10]

Dry run: Try jobs failed on following builders:
  android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)

[AlexG, 2016-04-18 20:30:03]

lgtm

https://codereview.webrtc.org/1900483004/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1900483004/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler.cc:51: static const int
kVgaBitrateThresholdKbps = 500;
Why not to keep all these constants at the start where all constants are
declared.
Mixing constants declaration and code looks a little messy.

[pbos-webrtc, 2016-04-18 20:40:07]

move constants

[pbos-webrtc, 2016-04-18 20:41:45]

https://codereview.webrtc.org/1900483004/diff/1/webrtc/modules/video_coding/u...
File webrtc/modules/video_coding/utility/quality_scaler.cc (right):

https://codereview.webrtc.org/1900483004/diff/1/webrtc/modules/video_coding/u...
webrtc/modules/video_coding/utility/quality_scaler.cc:51: static const int
kVgaBitrateThresholdKbps = 500;
On 2016/04/18 20:30:03, AlexG wrote:
> Why not to keep all these constants at the start where all constants are
> declared.
> Mixing constants declaration and code looks a little messy.

Done.

[pbos-webrtc, 2016-04-18 20:46:10]

Description was changed from

==========
Add QVGA to thresholds for initial quality.

Makes QualityScaler start at QVGA for <250k initial bitrates. Useful in
combination with overriding max bitrates to a max lower than that for
connections where we know that the max bitrate is capped below where VGA
is useful.

BUG=webrtc:5678
R=glaznev@webrtc.org
==========

to

==========
Add QVGA to thresholds for initial quality.

Makes QualityScaler start at QVGA for <250k initial bitrates. Useful in
combination with overriding max bitrates to a max lower than that for
connections where we know that the max bitrate is capped below where VGA
is useful.

BUG=webrtc:5678
R=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/b9e77097ed200ce671ce4c10b...
==========

[commit-bot: I haz the power, 2016-04-18 20:46:11]

Description was changed from

==========
Add QVGA to thresholds for initial quality.

Makes QualityScaler start at QVGA for <250k initial bitrates. Useful in
combination with overriding max bitrates to a max lower than that for
connections where we know that the max bitrate is capped below where VGA
is useful.

BUG=webrtc:5678
R=glaznev@webrtc.org

Committed:
https://chromium.googlesource.com/external/webrtc/+/b9e77097ed200ce671ce4c10b...
==========

to

==========
Add QVGA to thresholds for initial quality.

Makes QualityScaler start at QVGA for <250k initial bitrates. Useful in
combination with overriding max bitrates to a max lower than that for
connections where we know that the max bitrate is capped below where VGA
is useful.

BUG=webrtc:5678
R=glaznev@webrtc.org

Committed: https://crrev.com/b9e77097ed200ce671ce4c10bf624211db6b5665
Cr-Commit-Position: refs/heads/master@{#12416}
==========

[pbos-webrtc, 2016-04-18 20:46:11]

Committed patchset #2 (id:20001) manually as
b9e77097ed200ce671ce4c10bf624211db6b5665 (presubmit successful).

[commit-bot: I haz the power, 2016-04-18 20:46:12]

Patchset 2 (id:??) landed as
https://crrev.com/b9e77097ed200ce671ce4c10bf624211db6b5665
Cr-Commit-Position: refs/heads/master@{#12416}