Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Issue 1900413002: VideoCapturerAndroid: Remove deprecated create function with egl context argument (Closed)

Created:
4 years, 8 months ago by magjed_webrtc
Modified:
4 years, 7 months ago
Reviewers:
AlexG, perkj_webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

VideoCapturerAndroid: Remove deprecated create function with egl context argument R=glaznev@webrtc.org, perkj@webrtc.org Committed: https://chromium.googlesource.com/external/webrtc/+/d1d96b2508f2226c61b100504657e28a8bbbc5d5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -16 lines) Patch
M webrtc/api/androidtests/src/org/webrtc/VideoCapturerAndroidTest.java View 1 chunk +0 lines, -9 lines 0 comments Download
M webrtc/api/java/android/org/webrtc/VideoCapturerAndroid.java View 1 chunk +0 lines, -6 lines 0 comments Download
M webrtc/examples/androidapp/src/org/appspot/apprtc/PeerConnectionClient.java View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 18 (8 generated)
magjed_webrtc
perkj - Please take a look.
4 years, 8 months ago (2016-04-20 09:46:18 UTC) #2
perkj_webrtc
lgtm
4 years, 8 months ago (2016-04-20 13:58:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900413002/1
4 years, 8 months ago (2016-04-20 13:58:41 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: presubmit on tryserver.webrtc (JOB_FAILED, http://build.chromium.org/p/tryserver.webrtc/builders/presubmit/builds/4962)
4 years, 8 months ago (2016-04-20 14:04:16 UTC) #7
magjed_webrtc
Alex - Please take a look.
4 years, 7 months ago (2016-04-27 07:58:40 UTC) #9
AlexG
lgtm
4 years, 7 months ago (2016-04-27 16:40:51 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1900413002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1900413002/1
4 years, 7 months ago (2016-04-29 11:59:23 UTC) #12
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-04-29 14:00:06 UTC) #14
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d1d96b2508f2226c61b100504657e28a8bbbc5d5 Cr-Commit-Position: refs/heads/master@{#12587}
4 years, 7 months ago (2016-05-02 07:43:38 UTC) #17
magjed_webrtc
4 years, 7 months ago (2016-05-02 07:43:39 UTC) #18
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d1d96b2508f2226c61b100504657e28a8bbbc5d5 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698