webrtc/video/send_statistics_proxy_unittest.cc - Issue 1900193004: Remove VCMPacketizationCallback

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/video/send_statistics_proxy_unittest.cc

Issue 1900193004: Remove VCMPacketizationCallback (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed offline comments. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: webrtc/video/send_statistics_proxy_unittest.cc

diff --git a/webrtc/video/send_statistics_proxy_unittest.cc b/webrtc/video/send_statistics_proxy_unittest.cc

index eb77a278877050ff8804c8e97ee5f168665a2875..ce90358b70002d90598aa9a287e5dfc15f2a6ce0 100644

--- a/webrtc/video/send_statistics_proxy_unittest.cc

+++ b/webrtc/video/send_statistics_proxy_unittest.cc

@@ -147,7 +147,7 @@ TEST_F(SendStatisticsProxyTest, EncodedBitrateAndFramerate) {

int media_bitrate_bps = 500;

int encode_fps = 29;

- statistics_proxy_->OnOutgoingRate(encode_fps, media_bitrate_bps);

+ statistics_proxy_->OnOutgoingRate(encode_fps, media_bitrate_bps, "");

stefan-webrtc 2016/04/26 08:51:58 Why not test the encoder name here too?

perkj_webrtc 2016/04/27 09:01:24 Done.

VideoSendStream::Stats stats = statistics_proxy_->GetStats();

EXPECT_EQ(media_bitrate_bps, stats.media_bitrate_bps);