Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: webrtc/base/objc/RTCLogging.h

Issue 1899573002: Mark public ObjC APIs as explicitly visible. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Add RTCDataBuffer Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « webrtc/base/objc/RTCFileLogger.h ('k') | webrtc/base/objc/RTCMacros.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/base/objc/RTCLogging.h
diff --git a/webrtc/base/objc/RTCLogging.h b/webrtc/base/objc/RTCLogging.h
index fbc4ffade279ef83175e31cc15f8945d97c42614..ffeb65aceee5607402af8d13c2fa76e9ed0ae2e3 100644
--- a/webrtc/base/objc/RTCLogging.h
+++ b/webrtc/base/objc/RTCLogging.h
@@ -10,6 +10,8 @@
#import <Foundation/Foundation.h>
+#import "webrtc/base/objc/RTCMacros.h"
+
// Subset of rtc::LoggingSeverity.
typedef NS_ENUM(NSInteger, RTCLoggingSeverity) {
RTCLoggingSeverityVerbose,
@@ -18,24 +20,16 @@ typedef NS_ENUM(NSInteger, RTCLoggingSeverity) {
RTCLoggingSeverityError,
};
-#if defined(__cplusplus)
-extern "C" void RTCLogEx(RTCLoggingSeverity severity, NSString* log_string);
-extern "C" void RTCSetMinDebugLogLevel(RTCLoggingSeverity severity);
-extern "C" NSString* RTCFileName(const char* filePath);
-#else
-
// Wrapper for C++ LOG(sev) macros.
// Logs the log string to the webrtc logstream for the given severity.
-extern void RTCLogEx(RTCLoggingSeverity severity, NSString* log_string);
+RTC_EXTERN void RTCLogEx(RTCLoggingSeverity severity, NSString* log_string);
// Wrapper for rtc::LogMessage::LogToDebug.
// Sets the minimum severity to be logged to console.
-extern void RTCSetMinDebugLogLevel(RTCLoggingSeverity severity);
+RTC_EXTERN void RTCSetMinDebugLogLevel(RTCLoggingSeverity severity);
// Returns the filename with the path prefix removed.
-extern NSString* RTCFileName(const char* filePath);
-
-#endif
+RTC_EXTERN NSString* RTCFileName(const char* filePath);
// Some convenience macros.
« no previous file with comments | « webrtc/base/objc/RTCFileLogger.h ('k') | webrtc/base/objc/RTCMacros.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698