Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1899573002: Mark public ObjC APIs as explicitly visible. (Closed)

Created:
4 years, 8 months ago by tkchin_webrtc
Modified:
4 years, 8 months ago
Reviewers:
Chuck
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Mark public ObjC APIs as explicitly visible. BUG= Committed: https://crrev.com/8b577ed5317f877daaf33a55240f75e499730c0a Cr-Commit-Position: refs/heads/master@{#12431}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : Add RTCDataBuffer #

Unified diffs Side-by-side diffs Delta from patch set Stats (+97 lines, -25 lines) Patch
M webrtc/api/objc/RTCAVFoundationVideoSource.h View 2 chunks +2 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCAudioTrack.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCConfiguration.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCDataChannel.h View 1 3 chunks +5 lines, -1 line 0 comments Download
M webrtc/api/objc/RTCDataChannelConfiguration.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCEAGLVideoView.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCIceCandidate.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCIceServer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCMediaConstraints.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCMediaStream.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCMediaStreamTrack.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCOpenGLVideoRenderer.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCPeerConnection.h View 3 chunks +4 lines, -1 line 0 comments Download
M webrtc/api/objc/RTCPeerConnectionFactory.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCRtpEncodingParameters.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCRtpParameters.h View 1 chunk +2 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCRtpSender.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCSessionDescription.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCStatsReport.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCVideoFrame.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCVideoRenderer.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCVideoSource.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/api/objc/RTCVideoTrack.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/base/objc/RTCCameraPreviewView.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/base/objc/RTCDispatcher.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/base/objc/RTCFieldTrials.h View 2 chunks +3 lines, -3 lines 0 comments Download
M webrtc/base/objc/RTCFileLogger.h View 2 chunks +3 lines, -0 lines 0 comments Download
M webrtc/base/objc/RTCLogging.h View 2 chunks +5 lines, -11 lines 0 comments Download
M webrtc/base/objc/RTCMacros.h View 1 chunk +4 lines, -2 lines 0 comments Download
M webrtc/base/objc/RTCSSLAdapter.h View 1 chunk +2 lines, -2 lines 0 comments Download
M webrtc/base/objc/RTCTracing.h View 1 chunk +4 lines, -4 lines 0 comments Download
M webrtc/base/objc/RTCUIApplication.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (11 generated)
tkchin_webrtc
4 years, 8 months ago (2016-04-18 23:10:37 UTC) #4
Chuck
lgtm https://codereview.webrtc.org/1899573002/diff/20001/webrtc/api/objc/RTCDataChannel.h File webrtc/api/objc/RTCDataChannel.h (right): https://codereview.webrtc.org/1899573002/diff/20001/webrtc/api/objc/RTCDataChannel.h#newcode18 webrtc/api/objc/RTCDataChannel.h:18: @interface RTCDataBuffer : NSObject Does this one need ...
4 years, 8 months ago (2016-04-18 23:24:06 UTC) #5
tkchin_webrtc
https://codereview.webrtc.org/1899573002/diff/20001/webrtc/api/objc/RTCDataChannel.h File webrtc/api/objc/RTCDataChannel.h (right): https://codereview.webrtc.org/1899573002/diff/20001/webrtc/api/objc/RTCDataChannel.h#newcode18 webrtc/api/objc/RTCDataChannel.h:18: @interface RTCDataBuffer : NSObject On 2016/04/18 23:24:06, Chuck wrote: ...
4 years, 8 months ago (2016-04-18 23:36:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899573002/40001
4 years, 8 months ago (2016-04-18 23:36:59 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-19 01:37:22 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899573002/40001
4 years, 8 months ago (2016-04-19 01:38:21 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-19 03:39:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899573002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899573002/40001
4 years, 8 months ago (2016-04-19 17:03:02 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 8 months ago (2016-04-19 17:04:45 UTC) #19
commit-bot: I haz the power
4 years, 8 months ago (2016-04-19 17:04:51 UTC) #21
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/8b577ed5317f877daaf33a55240f75e499730c0a
Cr-Commit-Position: refs/heads/master@{#12431}

Powered by Google App Engine
This is Rietveld 408576698