Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Issue 1899173002: Add defaulted move constructors for some types that just got copy constructors (Closed)

Created:
4 years, 8 months ago by kwiberg-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Add defaulted move constructors for some types that just got copy constructors They can all benefit from moving, since they contain std::string and std::vector. We intended to add these in https://codereview.webrtc.org/1896953004/, but got compiler errors we couldn't make sense of, so we skipped them. It turns out that what the compiler was complaining about was that when we said we'd have a user-defined move constructor, it stopped generating a copy assignment operator for us. This CL solves the problem by outfitting the types with defaulted copy and move assignment operators too. Committed: https://crrev.com/4fb3d2bcca968e8a0f29d8a20f67238f64f40102 Cr-Commit-Position: refs/heads/master@{#12469}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M webrtc/base/pathutils.h View 1 chunk +4 lines, -0 lines 0 comments Download
M webrtc/base/pathutils.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.h View 1 chunk +3 lines, -0 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/audio_encoder.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_region.h View 1 chunk +1 line, -0 lines 0 comments Download
M webrtc/modules/desktop_capture/desktop_region.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
kwiberg-webrtc
4 years, 8 months ago (2016-04-19 11:22:15 UTC) #2
kjellander_webrtc
lgtm. thanks!
4 years, 8 months ago (2016-04-19 16:36:05 UTC) #3
kwiberg-webrtc
On 2016/04/19 16:36:05, kjellander (webrtc) wrote: > lgtm. thanks! henrika@: ping?
4 years, 8 months ago (2016-04-22 02:09:41 UTC) #4
henrika_webrtc
LGTM
4 years, 8 months ago (2016-04-22 08:10:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899173002/1
4 years, 8 months ago (2016-04-22 09:24:07 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-22 11:24:50 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899173002/1
4 years, 8 months ago (2016-04-22 11:42:34 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-22 11:59:34 UTC) #12
commit-bot: I haz the power
4 years, 8 months ago (2016-04-22 11:59:43 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4fb3d2bcca968e8a0f29d8a20f67238f64f40102
Cr-Commit-Position: refs/heads/master@{#12469}

Powered by Google App Engine
This is Rietveld 408576698