Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: webrtc/modules/audio_processing/echo_cancellation_impl.cc

Issue 1899123002: Removed the issue with the leading semicolon in the audio processing module experiment description… (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: webrtc/modules/audio_processing/echo_cancellation_impl.cc
diff --git a/webrtc/modules/audio_processing/echo_cancellation_impl.cc b/webrtc/modules/audio_processing/echo_cancellation_impl.cc
index c18ed94bd2c1b97bb4157e610c647149bab41560..12527fc118e2a2dbdcf6cd6d903870499f88cb72 100644
--- a/webrtc/modules/audio_processing/echo_cancellation_impl.cc
+++ b/webrtc/modules/audio_processing/echo_cancellation_impl.cc
@@ -417,7 +417,10 @@ std::string EchoCancellationImpl::GetExperimentsDescription() {
rtc::CritScope cs(crit_capture_);
std::string description = (aec3_enabled_ ? "AEC3" : "");
if (refined_adaptive_filter_enabled_) {
- description += ";RefinedAdaptiveFilter";
+ if (description.size() > 0) {
hlundin-webrtc 2016/04/19 06:49:33 Isn't it better to have a semi-colon separated lis
peah-webrtc 2016/04/19 07:55:12 Awesome variant! :-). Done.
+ description += ";";
+ }
+ description += "RefinedAdaptiveFilter";
}
return description;
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698