Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1899123002:
Removed the issue with the leading semicolon in the audio processing module experiment description… (Closed)
|
Created:
4 years, 8 months ago by peah-webrtc Modified:
4 years, 8 months ago Reviewers:
hlundin-webrtc CC:
webrtc-reviews_webrtc.org, peah-webrtc, Andrew MacDonald, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, kwiberg-webrtc, minyue-webrtc, the sun, aluebs-webrtc, bjornv1 Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionRemoved the issue with the leading semicolon in the audio
processing module experiment description that was present
when AEC3 was not activated and when RefinedAdaptiveFilter
was activated.
BUG=webrtc:5778, webrtc:5777
Committed: https://crrev.com/f3669661bd4f68bad086bcc2cdb0c84ff2613b42
Cr-Commit-Position: refs/heads/master@{#12424}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Changes in response to reviewer comments #Messages
Total messages: 17 (8 generated)
Description was changed from ========== Removes the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 ========== to ========== Removes the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 ==========
Description was changed from ========== Removes the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 ========== to ========== Removed the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 ==========
peah@webrtc.org changed reviewers: + henrik.lundin@webrtc.org
The CQ bit was checked by peah@webrtc.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899123002/1
https://codereview.webrtc.org/1899123002/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/echo_cancellation_impl.cc (right): https://codereview.webrtc.org/1899123002/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/echo_cancellation_impl.cc:420: if (description.size() > 0) { Isn't it better to have a semi-colon separated list that always ends the last item with a semi-colon? That way, each component would just have to make sure to add a semi-colon after the string(s) it inserts. And if it inserts nothing, no semi-colon is added either.
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
https://codereview.webrtc.org/1899123002/diff/1/webrtc/modules/audio_processi... File webrtc/modules/audio_processing/echo_cancellation_impl.cc (right): https://codereview.webrtc.org/1899123002/diff/1/webrtc/modules/audio_processi... webrtc/modules/audio_processing/echo_cancellation_impl.cc:420: if (description.size() > 0) { On 2016/04/19 06:49:33, hlundin-webrtc wrote: > Isn't it better to have a semi-colon separated list that always ends the last > item with a semi-colon? That way, each component would just have to make sure to > add a semi-colon after the string(s) it inserts. And if it inserts nothing, no > semi-colon is added either. Awesome variant! :-). Done.
lgtm
The CQ bit was checked by peah@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1899123002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1899123002/20001
Message was sent while issue was closed.
Description was changed from ========== Removed the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 ========== to ========== Removed the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Removed the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 ========== to ========== Removed the issue with the leading semicolon in the audio processing module experiment description that was present when AEC3 was not activated and when RefinedAdaptiveFilter was activated. BUG=webrtc:5778, webrtc:5777 Committed: https://crrev.com/f3669661bd4f68bad086bcc2cdb0c84ff2613b42 Cr-Commit-Position: refs/heads/master@{#12424} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/f3669661bd4f68bad086bcc2cdb0c84ff2613b42 Cr-Commit-Position: refs/heads/master@{#12424} |
