Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: webrtc/base/sslidentity_unittest.cc

Issue 1898383003: RTCCertificate serialization. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: Addressed nisse's comments Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« webrtc/base/sslidentity.h ('K') | « webrtc/base/sslidentity.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright 2011 The WebRTC Project Authors. All rights reserved. 2 * Copyright 2011 The WebRTC Project Authors. All rights reserved.
3 * 3 *
4 * Use of this source code is governed by a BSD-style license 4 * Use of this source code is governed by a BSD-style license
5 * that can be found in the LICENSE file in the root of the source 5 * that can be found in the LICENSE file in the root of the source
6 * tree. An additional intellectual property rights grant can be found 6 * tree. An additional intellectual property rights grant can be found
7 * in the file PATENTS. All contributing project authors may 7 * in the file PATENTS. All contributing project authors may
8 * be found in the AUTHORS file in the root of the source tree. 8 * be found in the AUTHORS file in the root of the source tree.
9 */ 9 */
10 10
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 166
167 ASSERT_TRUE(expected_len <= sizeof(DigestType)); 167 ASSERT_TRUE(expected_len <= sizeof(DigestType));
168 168
169 rv = test_cert_->ComputeDigest(algorithm, digest, sizeof(digest), 169 rv = test_cert_->ComputeDigest(algorithm, digest, sizeof(digest),
170 &digest_len); 170 &digest_len);
171 EXPECT_TRUE(rv); 171 EXPECT_TRUE(rv);
172 EXPECT_EQ(expected_len, digest_len); 172 EXPECT_EQ(expected_len, digest_len);
173 EXPECT_EQ(0, memcmp(digest, expected_digest, expected_len)); 173 EXPECT_EQ(0, memcmp(digest, expected_digest, expected_len));
174 } 174 }
175 175
176 private: 176 void TestCloningIdentity(const SSLIdentity& identity) {
177 // To PEM strings.
178 std::string priv_pem = identity.PrivateKeyToPemString();
179 std::string cert_pem = identity.certificate().ToPEMString();
180 // Clone from PEM strings.
181 rtc::scoped_ptr<SSLIdentity> clone(
182 SSLIdentity::FromPEMStrings(priv_pem, cert_pem));
183 EXPECT_TRUE(clone);
184 // Make sure the clone is identical to the original.
185 EXPECT_TRUE(identity == *clone);
186 ASSERT_EQ(identity.certificate().CertificateExpirationTime(),
187 clone->certificate().CertificateExpirationTime());
188
189 // At this point we are confident that the identities are identical. To be
190 // extra sure, we compare PEM strings of the clone with the original. Note
191 // that the PEM strings of two identities are not strictly guaranteed to be
192 // equal (they describe structs whose members could be listed in a different
193 // order, for example). But because the same function is used to produce
194 // both PEMs, its a good enough bet that this comparison will work. If the
195 // assumption stops holding in the future we can always remove this from the
196 // unittest.
197 std::string clone_priv_pem = clone->PrivateKeyToPemString();
198 std::string clone_cert_pem = clone->certificate().ToPEMString();
199 ASSERT_EQ(priv_pem, clone_priv_pem);
200 ASSERT_EQ(cert_pem, clone_cert_pem);
201 }
202
203 protected:
177 rtc::scoped_ptr<SSLIdentity> identity_rsa1_; 204 rtc::scoped_ptr<SSLIdentity> identity_rsa1_;
178 rtc::scoped_ptr<SSLIdentity> identity_rsa2_; 205 rtc::scoped_ptr<SSLIdentity> identity_rsa2_;
179 rtc::scoped_ptr<SSLIdentity> identity_ecdsa1_; 206 rtc::scoped_ptr<SSLIdentity> identity_ecdsa1_;
180 rtc::scoped_ptr<SSLIdentity> identity_ecdsa2_; 207 rtc::scoped_ptr<SSLIdentity> identity_ecdsa2_;
181 rtc::scoped_ptr<rtc::SSLCertificate> test_cert_; 208 rtc::scoped_ptr<rtc::SSLCertificate> test_cert_;
182 }; 209 };
183 210
184 TEST_F(SSLIdentityTest, FixedDigestSHA1) { 211 TEST_F(SSLIdentityTest, FixedDigestSHA1) {
185 TestDigestForFixedCert(rtc::DIGEST_SHA_1, 20, kTestCertSha1); 212 TestDigestForFixedCert(rtc::DIGEST_SHA_1, 20, kTestCertSha1);
186 } 213 }
(...skipping 25 matching lines...) Expand all
212 } 239 }
213 240
214 TEST_F(SSLIdentityTest, DigestSHA384) { 241 TEST_F(SSLIdentityTest, DigestSHA384) {
215 TestDigestForGeneratedCert(rtc::DIGEST_SHA_384, 48); 242 TestDigestForGeneratedCert(rtc::DIGEST_SHA_384, 48);
216 } 243 }
217 244
218 TEST_F(SSLIdentityTest, DigestSHA512) { 245 TEST_F(SSLIdentityTest, DigestSHA512) {
219 TestDigestForGeneratedCert(rtc::DIGEST_SHA_512, 64); 246 TestDigestForGeneratedCert(rtc::DIGEST_SHA_512, 64);
220 } 247 }
221 248
249 TEST_F(SSLIdentityTest, IdentityComparison) {
250 EXPECT_TRUE(*identity_rsa1_ == *identity_rsa1_);
251 EXPECT_FALSE(*identity_rsa1_ == *identity_rsa2_);
252 EXPECT_FALSE(*identity_rsa1_ == *identity_ecdsa1_);
253 EXPECT_FALSE(*identity_rsa1_ == *identity_ecdsa2_);
254
255 EXPECT_TRUE(*identity_rsa2_ == *identity_rsa2_);
256 EXPECT_FALSE(*identity_rsa2_ == *identity_ecdsa1_);
257 EXPECT_FALSE(*identity_rsa2_ == *identity_ecdsa2_);
258
259 EXPECT_TRUE(*identity_ecdsa1_ == *identity_ecdsa1_);
260 EXPECT_FALSE(*identity_ecdsa1_ == *identity_ecdsa2_);
261 }
262
222 TEST_F(SSLIdentityTest, FromPEMStringsRSA) { 263 TEST_F(SSLIdentityTest, FromPEMStringsRSA) {
264 // These PEM strings were created by generating an identity with
265 // |SSLIdentity::Generate| and invoking |identity->PrivateKeyToPemString()|
266 // and |identity->certificate().ToPEMString()|.
223 static const char kRSA_PRIVATE_KEY_PEM[] = 267 static const char kRSA_PRIVATE_KEY_PEM[] =
224 "-----BEGIN RSA PRIVATE KEY-----\n" 268 "-----BEGIN PRIVATE KEY-----\n"
225 "MIICdwIBADANBgkqhkiG9w0BAQEFAASCAmEwggJdAgEAAoGBAMYRkbhmI7kVA/rM\n" 269 "MIICdQIBADANBgkqhkiG9w0BAQEFAASCAl8wggJbAgEAAoGBALNu2P74IZBlpZ9g\n"
226 "czsZ+6JDhDvnkF+vn6yCAGuRPV03zuRqZtDy4N4to7PZu9PjqrRl7nDMXrG3YG9y\n" 270 "jdedrLDYoC6cstPFdqa5gXK+PQERy48oAOsw4jyAyuY9/37XDdIC/mGdKpd6xPAN\n"
227 "rlIAZ72KjcKKFAJxQyAKLCIdawKRyp8RdK3LEySWEZb0AV58IadqPZDTNHHRX8dz\n" 271 "7CvG2HEX/LFojIWnxlJPbRfCYFAwh1IKyGCTmhrv0zHphqlbiGAMDLerJcYhg5At\n"
228 "5aTSMsbbkZ+C/OzTnbiMqLL/vg6jAgMBAAECgYAvgOs4FJcgvp+TuREx7YtiYVsH\n" 272 "oTADgf0Q3O6QQPhEQb25h6nO/zNhAgMBAAECgYBmgxPSR2zVlF0VOxKOdvSsbHbH\n"
229 "mwQPTum2z/8VzWGwR8BBHBvIpVe1MbD/Y4seyI2aco/7UaisatSgJhsU46/9Y4fq\n" 273 "apr4Rj5Nbno4VduAeuwzM4Wi2ODH9ET3WcBYdQDeVPuERUiKFofhJfMh547LyP/M\n"
230 "2TwXH9QANf4at4d9n/R6rzwpAJOpgwZgKvdQjkfrKTtgLV+/dawvpxUYkRH4JZM1\n" 274 "laF0cqC0zJ1L7TB/z84eMYn+vQOI9fBAg98nUJ36CJboDCBYqH5mYLAqEjNhgg9f\n"
231 "CVGukMfKNrSVH4Ap4QJBAOJmGV1ASPnB4r4nc99at7JuIJmd7fmuVUwUgYi4XgaR\n" 275 "dF0YxByC2UQXekKoYQJBAN3fCCa6XvV0jaChnLJXHPqnK5sZ8MuV9VoRYqqHkDZH\n"
232 "WhScBsgYwZ/JoywdyZJgnbcrTDuVcWG56B3vXbhdpMsCQQDf9zeJrjnPZ3Cqm79y\n" 276 "ZfVJOxjECeD98HY0mikq5dClzeGre+03CPe76Wqp3h0CQQDPCKj1zd7ZqquGwVuf\n"
233 "kdqANep0uwZciiNiWxsQrCHztywOvbFhdp8iYVFG9EK8DMY41Y5TxUwsHD+67zao\n" 277 "JnFi4Ph6iaL/wGPSN6O0p2xJtv82heRzJYVwYBvcFO0+d/BdS4GGxhO8UeqN0BFN\n"
234 "ZNqJAkEA1suLUP/GvL8IwuRneQd2tWDqqRQ/Td3qq03hP7e77XtF/buya3Ghclo5\n" 278 "KvcVAkAhtXICmEw3FKcz4XnyKoQPnPhmDzHjbHwjXALWj9QcOwrFkoO1BovNsCcp\n"
235 "54czUR89QyVfJEC6278nzA7n2h1uVQJAcG6mztNL6ja/dKZjYZye2CY44QjSlLo0\n" 279 "fmJxoL/bzGUURT6F0te888LJ3tcNAkByaS2+ENP7Y+bAZHB2he8ZHowSY6dxQGep\n"
236 "MTgTSjdfg/28fFn2Jjtqf9Pi/X+50LWI/RcYMC2no606wRk9kyOuIQJBAK6VSAim\n" 280 "j1fniLI+FmP5RIrX2z9ft60NtX7aC7wIQqbEzQexBW/iiL5W78x1AkAjpkCJVyKh\n"
237 "1pOEjsYQn0X5KEIrz1G3bfCbB848Ime3U2/FWlCHMr6ch8kCZ5d1WUeJD3LbwMNG\n" 281 "YNr8DZgwY5RsN1O5KnKvHhNivgnwh6ND7mj3LzcUKKUQ8nnxK5QQ0HdD4DN8fcif\n"
238 "UCXiYxSsu20QNVw=\n" 282 "jcZp1fF/IoAm\n"
239 "-----END RSA PRIVATE KEY-----\n"; 283 "-----END PRIVATE KEY-----\n";
240
241 static const char kCERT_PEM[] = 284 static const char kCERT_PEM[] =
242 "-----BEGIN CERTIFICATE-----\n" 285 "-----BEGIN CERTIFICATE-----\n"
243 "MIIBmTCCAQKgAwIBAgIEbzBSAjANBgkqhkiG9w0BAQsFADARMQ8wDQYDVQQDEwZX\n" 286 "MIIBnDCCAQWgAwIBAgIJAOoVB4d2ANmKMA0GCSqGSIb3DQEBCwUAMBAxDjAMBgNV\n"
244 "ZWJSVEMwHhcNMTQwMTAyMTgyNDQ3WhcNMTQwMjAxMTgyNDQ3WjARMQ8wDQYDVQQD\n" 287 "BAMMBXRlc3QxMB4XDTE2MDQxOTE0MjkyOVoXDTE2MDUyMDE0MjkyOVowEDEOMAwG\n"
245 "EwZXZWJSVEMwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBAMYRkbhmI7kVA/rM\n" 288 "A1UEAwwFdGVzdDEwgZ8wDQYJKoZIhvcNAQEBBQADgY0AMIGJAoGBALNu2P74IZBl\n"
246 "czsZ+6JDhDvnkF+vn6yCAGuRPV03zuRqZtDy4N4to7PZu9PjqrRl7nDMXrG3YG9y\n" 289 "pZ9gjdedrLDYoC6cstPFdqa5gXK+PQERy48oAOsw4jyAyuY9/37XDdIC/mGdKpd6\n"
247 "rlIAZ72KjcKKFAJxQyAKLCIdawKRyp8RdK3LEySWEZb0AV58IadqPZDTNHHRX8dz\n" 290 "xPAN7CvG2HEX/LFojIWnxlJPbRfCYFAwh1IKyGCTmhrv0zHphqlbiGAMDLerJcYh\n"
248 "5aTSMsbbkZ+C/OzTnbiMqLL/vg6jAgMBAAEwDQYJKoZIhvcNAQELBQADgYEAUflI\n" 291 "g5AtoTADgf0Q3O6QQPhEQb25h6nO/zNhAgMBAAEwDQYJKoZIhvcNAQELBQADgYEA\n"
249 "VUe5Krqf5RVa5C3u/UTAOAUJBiDS3VANTCLBxjuMsvqOG0WvaYWP3HYPgrz0jXK2\n" 292 "hjEs1dqYyw5wM0W8uZVzh2d91d4Liw0esMLw0yoPMe77nlBrNyJEDwDsiYMDAGmM\n"
250 "LJE/mGw3MyFHEqi81jh95J+ypl6xKW6Rm8jKLR87gUvCaVYn/Z4/P3AqcQTB7wOv\n" 293 "l/iF3KYb2s+JHuEjqc7LDT/vWn9h5dnuqUwKvDfxE1LFtToOdYBFfHSqNi3OeYAH\n"
251 "UD0A8qfhfDM+LK6rPAnCsVN0NRDY3jvd6rzix9M=\n" 294 "bMN9f0lmbtRKvMKV0FciIlUpT2vfkRD8Dtz1S1EC3hw=\n"
252 "-----END CERTIFICATE-----\n"; 295 "-----END CERTIFICATE-----\n";
253 296
254 rtc::scoped_ptr<SSLIdentity> identity( 297 rtc::scoped_ptr<SSLIdentity> identity(
255 SSLIdentity::FromPEMStrings(kRSA_PRIVATE_KEY_PEM, kCERT_PEM)); 298 SSLIdentity::FromPEMStrings(kRSA_PRIVATE_KEY_PEM, kCERT_PEM));
256 EXPECT_TRUE(identity); 299 EXPECT_TRUE(identity);
300 EXPECT_EQ(kRSA_PRIVATE_KEY_PEM, identity->PrivateKeyToPemString());
257 EXPECT_EQ(kCERT_PEM, identity->certificate().ToPEMString()); 301 EXPECT_EQ(kCERT_PEM, identity->certificate().ToPEMString());
258 } 302 }
259 303
260 TEST_F(SSLIdentityTest, FromPEMStringsEC) { 304 TEST_F(SSLIdentityTest, FromPEMStringsEC) {
261 static const char kRSA_PRIVATE_KEY_PEM[] = 305 // These PEM strings were created by generating an identity with
262 "-----BEGIN EC PRIVATE KEY-----\n" 306 // |SSLIdentity::Generate| and invoking |identity->PrivateKeyToPemString()|
263 "MHcCAQEEIKkIztWLPbs4Y2zWv7VW2Ov4is2ifleCuPgRB8fRv3IkoAoGCCqGSM49\n" 307 // and |identity->certificate().ToPEMString()|.
264 "AwEHoUQDQgAEDPV33NrhSdhg9cBRkUWUXnVMXc3h17i9ARbSmNgminKcBXb8/y8L\n" 308 static const char kECDSA_PRIVATE_KEY_PEM[] =
265 "A76cMWQPPM0ybHO8OS7ZVg2U/m+TwE1M2g==\n" 309 "-----BEGIN PRIVATE KEY-----\n"
266 "-----END EC PRIVATE KEY-----\n"; 310 "MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQgMLDPZD/SzV5hyG31\n"
311 "avokBljFHTA4glgp+xnWCEOUKk6hRANCAATgH/3UTWsznXg2bHiDyLasfzDuDbIs\n"
312 "+gGfmo80ahvYe9F8ErC0N8RZve0GAzSrWSfoKosc9nA3KTTe3VxYTT34\n"
313 "-----END PRIVATE KEY-----\n";
267 static const char kCERT_PEM[] = 314 static const char kCERT_PEM[] =
268 "-----BEGIN CERTIFICATE-----\n" 315 "-----BEGIN CERTIFICATE-----\n"
269 "MIIB0jCCAXmgAwIBAgIJAMCjpFt9t6LMMAoGCCqGSM49BAMCMEUxCzAJBgNVBAYT\n" 316 "MIIBFDCBu6ADAgECAgkA+w+/nByFy7EwCgYIKoZIzj0EAwIwEDEOMAwGA1UEAwwF\n"
270 "AkFVMRMwEQYDVQQIDApTb21lLVN0YXRlMSEwHwYDVQQKDBhJbnRlcm5ldCBXaWRn\n" 317 "dGVzdDMwHhcNMTYwNDE5MTQxNjAyWhcNMTYwNTIwMTQxNjAyWjAQMQ4wDAYDVQQD\n"
271 "aXRzIFB0eSBMdGQwIBcNMTUwNjMwMTMwMTIyWhgPMjI4OTA0MTMxMzAxMjJaMEUx\n" 318 "DAV0ZXN0MzBZMBMGByqGSM49AgEGCCqGSM49AwEHA0IABOAf/dRNazOdeDZseIPI\n"
272 "CzAJBgNVBAYTAkFVMRMwEQYDVQQIDApTb21lLVN0YXRlMSEwHwYDVQQKDBhJbnRl\n" 319 "tqx/MO4Nsiz6AZ+ajzRqG9h70XwSsLQ3xFm97QYDNKtZJ+gqixz2cDcpNN7dXFhN\n"
273 "cm5ldCBXaWRnaXRzIFB0eSBMdGQwWTATBgcqhkjOPQIBBggqhkjOPQMBBwNCAAQM\n" 320 "PfgwCgYIKoZIzj0EAwIDSAAwRQIgbLGkSJZ3uJ2uAOrz8lIqWKUiHXe8ejBPG57P\n"
274 "9Xfc2uFJ2GD1wFGRRZRedUxdzeHXuL0BFtKY2CaKcpwFdvz/LwsDvpwxZA88zTJs\n" 321 "vxegTWICIQCN34hvg8yXgcytAUrkW78KFcRS4RNL1TJ7NAg+JbJGnQ==\n"
275 "c7w5LtlWDZT+b5PATUzao1AwTjAdBgNVHQ4EFgQUYHq6nxNNIE832ZmaHc/noODO\n"
276 "rtAwHwYDVR0jBBgwFoAUYHq6nxNNIE832ZmaHc/noODOrtAwDAYDVR0TBAUwAwEB\n"
277 "/zAKBggqhkjOPQQDAgNHADBEAiAQRojsTyZG0BlKoU7gOt5h+yAMLl2cxmDtOIQr\n"
278 "GWP/PwIgJynB4AUDsPT0DWmethOXYijB5sY5UPd9DvgmiS/Mr6s=\n"
279 "-----END CERTIFICATE-----\n"; 322 "-----END CERTIFICATE-----\n";
280 323
281 rtc::scoped_ptr<SSLIdentity> identity( 324 rtc::scoped_ptr<SSLIdentity> identity(
282 SSLIdentity::FromPEMStrings(kRSA_PRIVATE_KEY_PEM, kCERT_PEM)); 325 SSLIdentity::FromPEMStrings(kECDSA_PRIVATE_KEY_PEM, kCERT_PEM));
283 EXPECT_TRUE(identity); 326 EXPECT_TRUE(identity);
327 EXPECT_EQ(kECDSA_PRIVATE_KEY_PEM, identity->PrivateKeyToPemString());
284 EXPECT_EQ(kCERT_PEM, identity->certificate().ToPEMString()); 328 EXPECT_EQ(kCERT_PEM, identity->certificate().ToPEMString());
285 } 329 }
286 330
331 TEST_F(SSLIdentityTest, CloneIdentityRSA) {
332 TestCloningIdentity(*identity_rsa1_);
333 TestCloningIdentity(*identity_rsa2_);
334 }
335
336 TEST_F(SSLIdentityTest, CloneIdentityECDSA) {
337 TestCloningIdentity(*identity_ecdsa1_);
338 TestCloningIdentity(*identity_ecdsa2_);
339 }
340
287 TEST_F(SSLIdentityTest, PemDerConversion) { 341 TEST_F(SSLIdentityTest, PemDerConversion) {
288 std::string der; 342 std::string der;
289 EXPECT_TRUE(SSLIdentity::PemToDer("CERTIFICATE", kTestCertificate, &der)); 343 EXPECT_TRUE(SSLIdentity::PemToDer("CERTIFICATE", kTestCertificate, &der));
290 344
291 EXPECT_EQ(kTestCertificate, SSLIdentity::DerToPem( 345 EXPECT_EQ(kTestCertificate, SSLIdentity::DerToPem(
292 "CERTIFICATE", 346 "CERTIFICATE",
293 reinterpret_cast<const unsigned char*>(der.data()), der.length())); 347 reinterpret_cast<const unsigned char*>(der.data()), der.length()));
294 } 348 }
295 349
296 TEST_F(SSLIdentityTest, GetSignatureDigestAlgorithm) { 350 TEST_F(SSLIdentityTest, GetSignatureDigestAlgorithm) {
(...skipping 111 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 } 462 }
409 }; 463 };
410 464
411 TEST_F(SSLIdentityExpirationTest, TestASN1TimeToSec) { 465 TEST_F(SSLIdentityExpirationTest, TestASN1TimeToSec) {
412 TestASN1TimeToSec(); 466 TestASN1TimeToSec();
413 } 467 }
414 468
415 TEST_F(SSLIdentityExpirationTest, TestExpireTime) { 469 TEST_F(SSLIdentityExpirationTest, TestExpireTime) {
416 TestExpireTime(500); 470 TestExpireTime(500);
417 } 471 }
OLDNEW
« webrtc/base/sslidentity.h ('K') | « webrtc/base/sslidentity.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698