Fix compilation of rtc_base_objc on iOS when building as part of Chromium.

Fix compilation of rtc_base_objc on iOS when building as part of Chromium.

When building as part of Chromium, webrtc/base/logging.h is overridden
by webrtc_overrides/webrtc/base/logging.h that uses Chromium logging
macros.

The implementation of webrtc/base/objc/RTCFileLogger.{h,mm} however has
dependency on the webrtc implementation of logging as it define a class
that inherits from rtc::LogSink. Since the class does not exists when
the overrides are used, the file fails compilation.

Fixes the compilation for iOS as part of Chromium by not compiling the
file webrtc/base/objc/RTCFileLogger.{h,mm} in that configuration.

BUG=459705
Committed: https://crrev.com/1a0c4611d7921216287c5dac0fa61b390a7ea915
Cr-Commit-Position: refs/heads/master@{#12438}

[sdefresne, 2016-04-19 18:16:06]

sdefresne@chromium.org changed reviewers:
+ kjellander@webrtc.org

[sdefresne, 2016-04-19 18:16:07]

Please take a look.

This fixes the following error while building Chromium for iOS:

In file included from ../../third_party/webrtc/base/objc/RTCFileLogger.mm:16:
../../third_party/webrtc/base/logsinks.h:25:36: error: expected class name
class FileRotatingLogSink : public LogSink {
                                   ^

I was surprised by this error at first, but after inspecting the preprocessed
file, I saw that third_party/webrtc/base/logging.h is not included but instead
third_party/webrtc_overrides/webrtc/base/logging.h.

[kjellander_webrtc, 2016-04-19 20:22:17]

lg, but can you do a similar change to
https://chromium.googlesource.com/external/webrtc/+/master/webrtc/base/base.g...
?

We're going to maintain both GYP and GN for some time and even if Chromium is
moving away from GYP we need to keep ours in sync

[sdefresne, 2016-04-20 07:47:23]

Done. PTAL.

[kjellander_webrtc, 2016-04-20 08:12:05]

kjellander@webrtc.org changed reviewers:
+ tkchin@webrtc.org

[kjellander_webrtc, 2016-04-20 08:12:05]

lgtm

+tkchin FYI

[sdefresne, 2016-04-20 08:18:13]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2016-04-20 08:18:13]

Thank you for the reviews.

[commit-bot: I haz the power, 2016-04-20 08:18:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1898283002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1898283002/20001

[commit-bot: I haz the power, 2016-04-20 08:44:58]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-04-20 08:45:08]

Description was changed from

==========
Fix compilation of rtc_base_objc on iOS when building as part of Chromium.

When building as part of Chromium, webrtc/base/logging.h is overridden
by webrtc_overrides/webrtc/base/logging.h that uses Chromium logging
macros.

The implementation of webrtc/base/objc/RTCFileLogger.{h,mm} however has
dependency on the webrtc implementation of logging as it define a class
that inherits from rtc::LogSink. Since the class does not exists when
the overrides are used, the file fails compilation.

Fixes the compilation for iOS as part of Chromium by not compiling the
file webrtc/base/objc/RTCFileLogger.{h,mm} in that configuration.

BUG=459705
==========

to

==========
Fix compilation of rtc_base_objc on iOS when building as part of Chromium.

When building as part of Chromium, webrtc/base/logging.h is overridden
by webrtc_overrides/webrtc/base/logging.h that uses Chromium logging
macros.

The implementation of webrtc/base/objc/RTCFileLogger.{h,mm} however has
dependency on the webrtc implementation of logging as it define a class
that inherits from rtc::LogSink. Since the class does not exists when
the overrides are used, the file fails compilation.

Fixes the compilation for iOS as part of Chromium by not compiling the
file webrtc/base/objc/RTCFileLogger.{h,mm} in that configuration.

BUG=459705

Committed: https://crrev.com/1a0c4611d7921216287c5dac0fa61b390a7ea915
Cr-Commit-Position: refs/heads/master@{#12438}
==========

[commit-bot: I haz the power, 2016-04-20 08:45:09]

Patchset 2 (id:??) landed as
https://crrev.com/1a0c4611d7921216287c5dac0fa61b390a7ea915
Cr-Commit-Position: refs/heads/master@{#12438}