webrtc/modules/video_coding/video_coding_impl.h - Issue 1897233002: Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/video_coding_impl.h

Issue 1897233002: Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Addressed pbos nits. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/utility/ivf_file_writer_unittest.cc ('k') | webrtc/modules/video_coding/video_coding_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/video_coding_impl.h

diff --git a/webrtc/modules/video_coding/video_coding_impl.h b/webrtc/modules/video_coding/video_coding_impl.h

index 40352b02dc65cb9b3c83ffd43cf1100e38dabd1c..e9d7abc9694751e18c468b31763f54bf093d193e 100644

--- a/webrtc/modules/video_coding/video_coding_impl.h

+++ b/webrtc/modules/video_coding/video_coding_impl.h

@@ -79,6 +79,8 @@ class VideoSender {

uint8_t lossRate,

int64_t rtt);

+ // Deprecated. Use |post_encode_callback| instead.

+ // TODO(perkj): Remove once |OnEncoderImplementationName| is not used.

int32_t RegisterTransportCallback(VCMPacketizationCallback* transport);

int32_t RegisterSendStatisticsCallback(VCMSendStatisticsCallback* sendStats);

int32_t RegisterProtectionCallback(VCMProtectionCallback* protection);