webrtc/modules/video_coding/video_coding_impl.cc - Issue 1897233002: Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/video_coding_impl.cc

Issue 1897233002: Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed simulcast idx when using kVideoCodecGeneric. Fixed merge error of rotation. Addressed stefans… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« webrtc/modules/video_coding/include/video_codec_interface.h ('K') | « webrtc/modules/video_coding/video_coding_impl.h ('k') | webrtc/modules/video_coding/video_sender_unittest.cc » ('j') | webrtc/video/video_send_stream_tests.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/video_coding_impl.cc

diff --git a/webrtc/modules/video_coding/video_coding_impl.cc b/webrtc/modules/video_coding/video_coding_impl.cc

index ee03753413eb9e4e8e95643575ac2052a166a752..a9a4724ecffa4283b6ddd27b0b985434a644e35b 100644

--- a/webrtc/modules/video_coding/video_coding_impl.cc

+++ b/webrtc/modules/video_coding/video_coding_impl.cc

@@ -54,7 +54,6 @@ class EncodedImageCallbackWrapper : public EncodedImageCallback {

callback_ = callback;

}

- // TODO(andresp): Change to void as return value is ignored.

pbos-webrtc 2016/04/19 14:59:24 TODO to change to bool, I dunno?

perkj_webrtc 2016/04/20 07:12:13 void make sence in the end. I will add a todo wher

virtual int32_t Encoded(const EncodedImage& encoded_image,

const CodecSpecificInfo* codec_specific_info,

const RTPFragmentationHeader* fragmentation) {