webrtc/modules/video_coding/include/video_codec_interface.h - Issue 1897233002: Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: webrtc/modules/video_coding/include/video_codec_interface.h

Issue 1897233002: Deprecate VCMPacketizationCallback::SendData and use EncodedImageCallback instead. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master

Patch Set: Fixed simulcast idx when using kVideoCodecGeneric. Fixed merge error of rotation. Addressed stefans… Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « webrtc/modules/video_coding/generic_encoder.cc ('k') | webrtc/modules/video_coding/include/video_coding_defines.h » ('j') | webrtc/modules/video_coding/video_coding_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: webrtc/modules/video_coding/include/video_codec_interface.h

diff --git a/webrtc/modules/video_coding/include/video_codec_interface.h b/webrtc/modules/video_coding/include/video_codec_interface.h

index 19303c0d6783ed47cdd07a7f7461ca059bc59e69..25ec3287bcbd039076da7313f91c75b678e18a74 100644

--- a/webrtc/modules/video_coding/include/video_codec_interface.h

+++ b/webrtc/modules/video_coding/include/video_codec_interface.h

@@ -90,6 +90,7 @@ union CodecSpecificInfoUnion {

// must be fitted with a copy-constructor. This is because it is copied

// in the copy-constructor of VCMEncodedFrame.

struct CodecSpecificInfo {

+ CodecSpecificInfo() { memset(this, 0, sizeof(CodecSpecificInfo)); }

pbos-webrtc 2016/04/19 14:59:24 Remove for now and do separately per our discussio

VideoCodecType codecType;

CodecSpecificInfoUnion codecSpecific;

};