Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1896413002: Reland of Initialize/configure video encoders asychronously. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
stefan-webrtc
CC:
webrtc-reviews_webrtc.org, video-team_agora.io, yujie_mao (webrtc), zhengzhonghou_agora.io, stefan-webrtc, tterriberry_mozilla.com, the sun, perkj_webrtc, mflodman, Pawel Osciak, wuchengli, nisse-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Reland of Initialize/configure video encoders asychronously. (patchset #1 id:1 of https://codereview.webrtc.org/1821983002/ ) Reason for revert: RTCVideoEncoder has been updated to not make assumptions on calling threads/post back to a worker thread. This should now be landable again. Original issue's description: > Revert of Initialize/configure video encoders asychronously. (patchset #4 id:60001 of https://codereview.webrtc.org/1757313002/ ) > > Reason for revert: > Breaks RTCVideoEncoder which has incorrect assumptions on where InitEncode etc. is called from. Temporarily reverting until RTCVideoEncoder has been updated. > > Original issue's description: > > Initialize/configure video encoders asychronously. > > > > Greatly speeds up setRemoteDescription() by moving encoder initialization > > off the main worker thread, which is free to move onto gathering ICE > > candidates and other tasks while InitEncode() is performed. It also > > un-blocks PeerConnection GetStats() which is no longer blocked on > > encoder initialization. > > > > BUG=webrtc:5410 > > R=stefan@webrtc.org > > > > Committed: https://chromium.googlesource.com/external/webrtc/+/fb647a67be94bb3c940d8b5fba01972f7ce91a29 > > R=stefan@webrtc.org > # Not skipping CQ checks because original CL landed more than 1 days ago. > BUG=chromium:595274, chromium:595308, webrtc:5410 > > Committed: https://crrev.com/81cbd924447d507559dbd6e6d1f9fe439fcf2716 > Cr-Commit-Position: refs/heads/master@{#12086} TBR=stefan@webrtc.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=chromium:595274, chromium:595308, webrtc:5410 Committed: https://crrev.com/14fe708f3d6357a3e3f9b62d8a6a9e310af86fcd Cr-Commit-Position: refs/heads/master@{#12446}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : rebase2 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -172 lines) Patch
M webrtc/media/engine/fakewebrtcvideoengine.h View 1 6 chunks +30 lines, -8 lines 0 comments Download
M webrtc/media/engine/webrtcvideoengine2_unittest.cc View 1 6 chunks +11 lines, -4 lines 0 comments Download
M webrtc/video/video_quality_test.cc View 1 2 10 chunks +53 lines, -6 lines 0 comments Download
M webrtc/video/video_send_stream.h View 1 3 chunks +8 lines, -0 lines 0 comments Download
M webrtc/video/video_send_stream.cc View 1 4 chunks +185 lines, -149 lines 0 comments Download
M webrtc/video/video_send_stream_tests.cc View 1 15 chunks +36 lines, -5 lines 0 comments Download

Messages

Total messages: 16 (6 generated)
pbos-webrtc
Created Reland of Initialize/configure video encoders asychronously.
4 years, 8 months ago (2016-04-20 09:45:30 UTC) #1
pbos-webrtc
rebase
4 years, 8 months ago (2016-04-20 10:13:07 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896413002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896413002/130001
4 years, 8 months ago (2016-04-20 10:14:50 UTC) #4
pbos-webrtc
+cc perkj@,nisse@: This is the CL that'll let us post video frames from a non-worker ...
4 years, 8 months ago (2016-04-20 10:20:12 UTC) #5
pbos-webrtc
On 2016/04/20 10:20:12, pbos-webrtc wrote: > +cc perkj@,nisse@: This is the CL that'll let us ...
4 years, 8 months ago (2016-04-20 10:20:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896413002/130001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896413002/130001
4 years, 8 months ago (2016-04-20 12:34:14 UTC) #9
pbos-webrtc
rebase2
4 years, 8 months ago (2016-04-20 12:34:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1896413002/150001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1896413002/150001
4 years, 8 months ago (2016-04-20 12:34:43 UTC) #13
commit-bot: I haz the power
Committed patchset #3 (id:150001)
4 years, 8 months ago (2016-04-20 13:36:00 UTC) #14
commit-bot: I haz the power
4 years, 8 months ago (2016-04-20 13:58:04 UTC) #16
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/14fe708f3d6357a3e3f9b62d8a6a9e310af86fcd
Cr-Commit-Position: refs/heads/master@{#12446}

Powered by Google App Engine
This is Rietveld 408576698