Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(225)

Issue 1894283002: Fixing a segfault that can occur when changing the track of an RtpSender. (Closed)

Created:
4 years, 8 months ago by Taylor Brandstetter
Modified:
4 years, 7 months ago
Reviewers:
pthatcher1
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Fixing a segfault that can occur when changing the track of an RtpSender. The reference to the old track needs to be kept alive until SetAudioSend/ SetSource is called, because otherwise it could be deleted while the audio/ video engine is still trying to use the track. BUG=webrtc:5796 Committed: https://crrev.com/5dd42fd849062373cab757605824254fc16db6b6 Cr-Commit-Position: refs/heads/master@{#12598}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -5 lines) Patch
M webrtc/api/rtpsender.cc View 2 chunks +6 lines, -0 lines 0 comments Download
M webrtc/api/rtpsenderreceiver_unittest.cc View 3 chunks +24 lines, -5 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
Taylor Brandstetter
4 years, 8 months ago (2016-04-22 17:51:21 UTC) #3
pthatcher1
lgtm
4 years, 7 months ago (2016-04-29 22:32:58 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894283002/1
4 years, 7 months ago (2016-05-02 19:58:23 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 7 months ago (2016-05-02 21:58:49 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1894283002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1894283002/1
4 years, 7 months ago (2016-05-02 23:18:27 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 7 months ago (2016-05-02 23:20:06 UTC) #12
commit-bot: I haz the power
4 years, 7 months ago (2016-05-02 23:20:15 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5dd42fd849062373cab757605824254fc16db6b6
Cr-Commit-Position: refs/heads/master@{#12598}

Powered by Google App Engine
This is Rietveld 408576698