Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc

Issue 1893313002: Use initial bitrates for software VP8. (Closed) Base URL: https://chromium.googlesource.com/external/webrtc.git@master
Patch Set: fix test codec bitrates to not hit initial downscale Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
diff --git a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
index abe58e362699534047322cc096554613f7f46acc..88ca85feade3626b1915ca4aeb4ded44be7b0f51 100644
--- a/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
+++ b/webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc
@@ -606,9 +606,8 @@ int VP8EncoderImpl::InitEncode(const VideoCodec* inst,
// go back down).
const int kLowQpThreshold = 29;
const int kDisabledBadQpThreshold = 100;
- // TODO(glaznev/sprang): consider passing codec initial bitrate to quality
- // scaler to avoid starting with HD for low initial bitrates.
- quality_scaler_.Init(kLowQpThreshold, kDisabledBadQpThreshold, false, 0, 0, 0,
+ quality_scaler_.Init(kLowQpThreshold, kDisabledBadQpThreshold, false,
+ codec_.startBitrate, codec_.width, codec_.height,
codec_.maxFramerate);
// Only apply scaling to improve for single-layer streams. The scaling metrics

Powered by Google App Engine
This is Rietveld 408576698