Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1893313002: Use initial bitrates for software VP8. (Closed)

Created:
4 years, 8 months ago by pbos-webrtc
Modified:
4 years, 8 months ago
Reviewers:
AlexG, stefan-webrtc
CC:
webrtc-reviews_webrtc.org, tterriberry_mozilla.com, zhengzhonghou_agora.io, video-team_agora.io, stefan-webrtc, mflodman
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

Use initial bitrates for software VP8. Makes the software encoder start at VGA as well, since ~300k isn't good enough to produce a good HD stream. BUG=webrtc:5678 R=glaznev@webrtc.org, stefan@webrtc.org Committed: https://crrev.com/e1da27e543bdb1983638118172a4efd599ca51b5 Cr-Commit-Position: refs/heads/master@{#12428}

Patch Set 1 #

Patch Set 2 : fix test codec bitrates to not hit initial downscale #

Total comments: 1

Patch Set 3 : verify that two streams start sending QVGA #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -4 lines) Patch
M webrtc/media/base/videoengine_unittest.h View 1 2 1 chunk +10 lines, -1 line 0 comments Download
M webrtc/modules/video_coding/codecs/vp8/vp8_impl.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 21 (9 generated)
pbos-webrtc
PTAL, starting at VGA also reduces blocky low-framerate start conditions.
4 years, 8 months ago (2016-04-18 11:40:12 UTC) #1
AlexG
lgtm
4 years, 8 months ago (2016-04-18 22:39:12 UTC) #4
pbos-webrtc
fix test codec bitrates to not hit initial downscale
4 years, 8 months ago (2016-04-18 22:56:11 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1893313002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1893313002/20001
4 years, 8 months ago (2016-04-18 22:59:09 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
4 years, 8 months ago (2016-04-19 00:59:40 UTC) #11
stefan-webrtc
Have you looked at how this affects appr.tc on a desktop? Just to make sure ...
4 years, 8 months ago (2016-04-19 06:46:37 UTC) #12
pbos-webrtc
verify that two streams start sending QVGA
4 years, 8 months ago (2016-04-19 13:50:28 UTC) #13
pbos-webrtc
desktop appr.tc looks fine, and is up to HD in ~2 seconds in loopback
4 years, 8 months ago (2016-04-19 13:50:52 UTC) #14
stefan-webrtc
lgtm
4 years, 8 months ago (2016-04-19 13:52:14 UTC) #16
pbos-webrtc
Committed patchset #3 (id:40001) manually as e1da27e543bdb1983638118172a4efd599ca51b5 (presubmit successful).
4 years, 8 months ago (2016-04-19 13:53:27 UTC) #19
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/e1da27e543bdb1983638118172a4efd599ca51b5 Cr-Commit-Position: refs/heads/master@{#12428}
4 years, 8 months ago (2016-04-19 13:53:27 UTC) #20
kjellander_webrtc
4 years, 8 months ago (2016-04-19 15:18:33 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.webrtc.org/1898183002/ by kjellander@webrtc.org.

The reason for reverting is: Likely broke Chromium:
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Linux%20Tester/buil...
https://build.chromium.org/p/chromium.webrtc.fyi/builders/Win10%20Tester/buil....

Powered by Google App Engine
This is Rietveld 408576698