Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1891703002:
Potential division by zero in RtpToNtpMs() (Closed)
|
Created:
4 years, 8 months ago by åsapersson Modified:
4 years, 8 months ago Reviewers:
mflodman CC:
webrtc-reviews_webrtc.org, henrika_webrtc, zhengzhonghou_agora.io, tterriberry_mozilla.com, fengyue_agora.io, peah-webrtc, mflodman Base URL:
https://chromium.googlesource.com/external/webrtc.git@master Target Ref:
refs/pending/heads/master Project:
webrtc Visibility:
Public. |
DescriptionPotential division by zero in RtpToNtpMs() in rtp_to_ntp.cc.
CalculateFrequency() results in zero frequency (floating point) if the RTP timestamps in the RTCP list are equal.
Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp.
BUG=webrtc:5780
Committed: https://crrev.com/fdca66910a09254a40735ea39ea68036ebd339c2
Cr-Commit-Position: refs/heads/master@{#12429}
Patch Set 1 : #Patch Set 2 : #Patch Set 3 : #
Messages
Total messages: 24 (13 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Potential division by zero in RtpToNtpMs() CalculateFrequency() results in zero frequency if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ========== to ========== Potential division by zero in RtpToNtpMs() CalculateFrequency() results in zero frequency if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ==========
asapersson@webrtc.org changed reviewers: + mflodman@webrtc.org
Description was changed from ========== Potential division by zero in RtpToNtpMs() CalculateFrequency() results in zero frequency if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ========== to ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ==========
LG. Would any of the three new test cases have resulted in the crash?
On 2016/04/14 12:31:20, mflodman wrote: > LG. Would any of the three new test cases have resulted in the crash? No, that would require calling RtpToNtpMs with two rtcp packets in the list having equal timestamps. The check is added in UpdateRtcpList (and assumes that the list is updated through this function).
Description was changed from ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ========== to ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency if the RTP timestamps in the RTCP list are equal.- Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ==========
Description was changed from ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency if the RTP timestamps in the RTCP list are equal.- Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ========== to ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency (floating point) if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ==========
lgtm
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891703002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891703002/60001
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_arm64_rel on tryserver.webrtc (JOB_TIMED_OUT, no build URL)
The CQ bit was checked by asapersson@webrtc.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891703002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891703002/60001
Message was sent while issue was closed.
Description was changed from ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency (floating point) if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ========== to ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency (floating point) if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ==========
Message was sent while issue was closed.
Committed patchset #3 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency (floating point) if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 ========== to ========== Potential division by zero in RtpToNtpMs() in rtp_to_ntp.cc. CalculateFrequency() results in zero frequency (floating point) if the RTP timestamps in the RTCP list are equal. Added check in UpdateRtcpList to not insert RTCP SR with the same RTP timestamp. BUG=webrtc:5780 Committed: https://crrev.com/fdca66910a09254a40735ea39ea68036ebd339c2 Cr-Commit-Position: refs/heads/master@{#12429} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/fdca66910a09254a40735ea39ea68036ebd339c2 Cr-Commit-Position: refs/heads/master@{#12429} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
