Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1891483006: We no longer use compilers that can't =default move construction and assignment (Closed)

Created:
4 years, 8 months ago by kwiberg-webrtc
Modified:
4 years, 8 months ago
CC:
webrtc-reviews_webrtc.org, kwiberg-webrtc, tlegrand-webrtc, tterriberry_mozilla.com, audio-team_agora.io, hlundin-webrtc, peah-webrtc, minyue-webrtc
Base URL:
https://chromium.googlesource.com/external/webrtc.git@master
Target Ref:
refs/pending/heads/master
Project:
webrtc
Visibility:
Public.

Description

We no longer use compilers that can't =default move construction and assignment Committed: https://crrev.com/6ca0a31708ed1ddb06c060ceed5c5d5170af485c Cr-Commit-Position: refs/heads/master@{#12376}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -26 lines) Patch
M webrtc/base/optional.h View 1 chunk +2 lines, -9 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/cng/audio_encoder_cng.cc View 1 chunk +1 line, -11 lines 0 comments Download
M webrtc/modules/audio_coding/codecs/red/audio_encoder_copy_red.cc View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
kwiberg-webrtc
Henrik: OWNER of webrtc/base/ Henrik: OWNER of webrtc/modules/audio_coding/
4 years, 8 months ago (2016-04-15 09:08:54 UTC) #2
hlundin-webrtc
webrtc/modules/audio_coding/: lgtm
4 years, 8 months ago (2016-04-15 10:37:06 UTC) #3
Henrik Grunell WebRTC
base lgtm
4 years, 8 months ago (2016-04-15 10:47:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1891483006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1891483006/1
4 years, 8 months ago (2016-04-15 12:21:24 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-15 12:25:00 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-15 12:25:09 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6ca0a31708ed1ddb06c060ceed5c5d5170af485c
Cr-Commit-Position: refs/heads/master@{#12376}

Powered by Google App Engine
This is Rietveld 408576698